GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-101845: pyspecific: Fix i18n for availability directive (GH-101846) by miss-islington · Pull Request #101852 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

pyspecific: Fix i18n for availability directive

If the directive has content, the previous code would nest paragraph
nodes from that content inside a general paragraph node, which confuses
Sphinx and leads it to drop the content when translating. Instead, use a
container node for the body.

Also use set_source_info so that any warnings have location info.
(cherry picked from commit 6ef6915)

Co-authored-by: Jean Abou-Samra [email protected]

  • Issue: Doc: content of availability directive lost in i18n #101845

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jeanas @miss-islington
pythongh-101845: pyspecific: Fix i18n for availability directive (pyt…
6db46e9
…honGH-101846)

pyspecific: Fix i18n for availability directive

If the directive has content, the previous code would nest paragraph
nodes from that content inside a general paragraph node, which confuses
Sphinx and leads it to drop the content when translating. Instead, use a
container node for the body.

Also use set_source_info so that any warnings have location info.
(cherry picked from commit 6ef6915)

Co-authored-by: Jean Abou-Samra <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Feb 12, 2023
This was referenced Feb 12, 2023
Doc: content of availability directive lost in i18n #101845
Closed
gh-101845: pyspecific: Fix i18n for availability directive #101846
Merged
@bedevere-bot bedevere-bot added the skip news label Feb 12, 2023
JulienPalard
JulienPalard approved these changes Feb 12, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 12, 2023
@miss-islington
miss-islington merged commit 1b73683 into python:3.11 Feb 12, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 12, 2023
@miss-islington
miss-islington deleted the backport-6ef6915-3.11 branch February 12, 2023 17:28
JulienPalard added a commit to python/python-docs-fr that referenced this pull request Feb 12, 2023
@JulienPalard Christophe Nanteuil
Make merge (#34)
c456065
Pour python/cpython#101852

Reviewed-on: https://git.afpy.org/AFPy/python-docs-fr/pulls/34
Co-authored-by: Julien Palard <[email protected]>
Co-committed-by: Julien Palard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @JulienPalard @bedevere-bot @jeanas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.