GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||
GeezerVison is showing github.com — gh-101865: Deprecate `co_lnotab` from code objects as per PEP 626 by sobolevn · Pull Request #101866 · python/cpython Conversation
|
| set $__sz = ((PyVarObject *)$__co->co_lnotab)->ob_size/2 | |
| set $__p = (unsigned char *)((PyBytesObject *)$__co->co_lnotab)->ob_sval |
But, since I have 0 experience with gdb it might take some time.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I've pushed my naive attempt to fix |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@markshannon friendly ping :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…cts as per PEP626" This reverts commit 06a79d9.
1ece35d to
1a6b7bb
Compare
co_lnotab from code objects as per PEP626co_lnotab from code objects as per PEP626
There was an error while loading. Please reload this page.
|
Failures do not seem related 🤔 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@markshannon do you have time to re-review this, please? :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@carljm maybe you can have a look? :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
We aren't obliged to remove co_lnotab in 3.14, but we can. Perhaps change the "will"s to "may"s.
Not sure what to do about Misc/gdbinit though.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Perhaps we should discuss the future of Misc/gdbinit in another issue, and not worry about it here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@markshannon thanks a lot for your review and for all your hard work on CPython!
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Shall we add a |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
co_lnotab from code objects as per PEP626co_lnotab from code objects as per PEP 626
There was an error while loading. Please reload this page.
|
I think that we can add "is deprecated since 3.12 and may be removed in 3.14". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sure, let's do something like that. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@markshannon I've solved the merge conflicts. I hope that this is ready to be merged when you have the time :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…26 (python#101866) Co-authored-by: Oleg Iarygin <[email protected]>
…26 (python#101866) Co-authored-by: Oleg Iarygin <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.