GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101865: Deprecate `co_lnotab` from code objects as per PEP 626 by sobolevn · Pull Request #101866 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I still have to fix these lines:

cpython/Misc/gdbinit

Lines 60 to 61 in 6ef6915

set $__sz = ((PyVarObject *)$__co->co_lnotab)->ob_size/2
set $__p = (unsigned char *)((PyBytesObject *)$__co->co_lnotab)->ob_sval

But, since I have 0 experience with gdb it might take some time.

  • Issue: co_lnotab must be removed in 3.12 according to PEP 626 #101865

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
sobolevn requested a review from markshannon as a code owner February 13, 2023 07:38
@bedevere-bot bedevere-bot added the awaiting review label Feb 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 13, 2023
co_lnotab must be removed in 3.12 according to PEP 626 #101865
Closed
@sobolevn

sobolevn commented Feb 13, 2023

Copy link
Copy Markdown
Member Author

I've pushed my naive attempt to fix gdb: since it only needs a current line f->f_lineno seems like a tool for the job. (again, this is my very first time working with gdb)

vasily-v-ryabov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn

sobolevn commented Feb 21, 2023

Copy link
Copy Markdown
Member Author

@markshannon friendly ping :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn added 3 commits February 21, 2023 17:02
@sobolevn
pythongh-101865: Remove deprecated co_lnotab from code objects as p…
06a79d9
…er PEP626
@sobolevn
Revert "pythongh-101865: Remove deprecated co_lnotab from code obje…
dd65849
…cts as per PEP626"

This reverts commit 06a79d9.
@sobolevn
Deprecate co_lnotab instead of removing it
1a6b7bb
@sobolevn
sobolevn force-pushed the issue-101865 branch from 1ece35d to 1a6b7bb Compare February 21, 2023 14:22
@sobolevn sobolevn changed the title gh-101865: Remove deprecated co_lnotab from code objects as per PEP626 gh-101865: Deprecate co_lnotab from code objects as per PEP626 Feb 21, 2023
@sobolevn
Update gdbinit
67a1c98
@sobolevn

sobolevn commented Feb 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Failures do not seem related 🤔

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev

arhadthedev commented Feb 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

test_implied_dirs_performance issue was fixed in gh-102225 so merging main should help.

sobolevn reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev
Merge branch 'main' into issue-101865
7d69360
@sobolevn

sobolevn commented Mar 11, 2023

Copy link
Copy Markdown
Member Author

@markshannon do you have time to re-review this, please? :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn

sobolevn commented Mar 18, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@carljm maybe you can have a look? :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

markshannon
markshannon reviewed Mar 18, 2023
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general.
We aren't obliged to remove co_lnotab in 3.14, but we can. Perhaps change the "will"s to "may"s.

Not sure what to do about Misc/gdbinit though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Misc/gdbinit Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Objects/codeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Mar 18, 2023

Copy link
Copy Markdown
Member

Perhaps we should discuss the future of Misc/gdbinit in another issue, and not worry about it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Address review
2fc556e
@sobolevn sobolevn mentioned this pull request Mar 18, 2023
What to do with Misc/gdbinit? #102809
Closed
@sobolevn

sobolevn commented Mar 18, 2023

Copy link
Copy Markdown
Member Author

@markshannon thanks a lot for your review and for all your hard work on CPython!

  1. I've addressed all your comments
  2. I've opened a new issue about Misc/gdbinit: What to do with Misc/gdbinit? #102809
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Mar 18, 2023

Copy link
Copy Markdown
Member

Shall we add a .. deprecated-removed: 3.12 3.14 in the main docs, somewhere near https://docs.python.org/3.12/reference/datamodel.html?highlight=co_lnotab ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk changed the title gh-101865: Deprecate co_lnotab from code objects as per PEP626 gh-101865: Deprecate co_lnotab from code objects as per PEP 626 Mar 18, 2023
@sobolevn

sobolevn commented Mar 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I think that we can add "is deprecated since 3.12 and may be removed in 3.14".
But this directive won't work, because it is a raw text:

  1. https://github.com/python/cpython/blame/3adb23a17d25e36bd80874e860835182d851623f/Doc/reference/datamodel.rst#L965
  2. https://github.com/python/cpython/blame/3adb23a17d25e36bd80874e860835182d851623f/Doc/reference/datamodel.rst#L992
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Mar 19, 2023

Copy link
Copy Markdown
Member

I think that we can add "is deprecated since 3.12 and may be removed in 3.14".

Sure, let's do something like that.

sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Address review
cba6b24
hugovk
hugovk approved these changes Mar 19, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 19, 2023
@sobolevn

sobolevn commented Mar 21, 2023

Copy link
Copy Markdown
Member Author

gdbinit was removed in #102854 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn added 2 commits March 21, 2023 09:55
@sobolevn
Merge branch 'main' into issue-101865
4cc08ea
@sobolevn
Merge branch 'main' into issue-101865
a35ada1
@sobolevn

sobolevn commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

@markshannon I've solved the merge conflicts. I hope that this is ready to be merged when you have the time :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Address review
0966c8c
@ambv
ambv merged commit 2a72125 into python:main Apr 3, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 3, 2023
gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this pull request Apr 8, 2023
@sobolevn @arhadthedev @gaogaotiantian
pythongh-101865: Deprecate co_lnotab from code objects as per PEP 6…
726a56e
…26 (python#101866)

Co-authored-by: Oleg Iarygin <[email protected]>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@sobolevn @arhadthedev @warsaw
pythongh-101865: Deprecate co_lnotab from code objects as per PEP 6…
2db2a84
…26 (python#101866)

Co-authored-by: Oleg Iarygin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon left review comments
@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sobolevn @arhadthedev @markshannon @hugovk @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.