GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101758: Add a Test For Single-Phase Init Module Variants by ericsnowcurrently · Pull Request #101891 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Feb 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The new test exercises the most important variants for single-phase init extension modules. We also add some explanation about those variants to import.c.

  • Issue: Isolate PyModuleDef to Each Interpreter for Extension/Builtin Modules #101758

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 5 commits February 13, 2023 14:48
@ericsnowcurrently
Factor out fix_up_extension().
6c9bd47
@ericsnowcurrently
Add an explanation about single-phase init variants.
8c0258a
@ericsnowcurrently
Add a TODO comment.
d5a0fe6
@ericsnowcurrently
Add the _testsinglephase_* modules.
97dee17
@ericsnowcurrently
Add test_imp.ImportTests.test_singlephase_variants.
83aaef1
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon, encukou, ncoghlan and warsaw as code owners February 13, 2023 22:46
@bedevere-bot bedevere-bot added the awaiting core review label Feb 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 13, 2023
Isolate PyModuleDef to Each Interpreter for Extension/Builtin Modules #101758
Closed
@ericsnowcurrently ericsnowcurrently added the skip news label Feb 13, 2023
ericsnowcurrently added 3 commits February 14, 2023 11:04
@ericsnowcurrently
Handle errors from _PyTime_GetMonotonicClock() correctly.
285fcb9
@ericsnowcurrently
Return seconds from mod.initialized() instead of nanoseconds.
250606a
@ericsnowcurrently
Make state->initialized strictly monotonic.
b7bf588
@ericsnowcurrently
ericsnowcurrently merged commit 096d009 into python:main Feb 14, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 14, 2023
@ericsnowcurrently
ericsnowcurrently deleted the test-legacy-extension-with-state branch February 14, 2023 21:26
@ericsnowcurrently ericsnowcurrently mentioned this pull request Feb 16, 2023
gh-101758: Fix Refleak Testing With test_singlephase_variants #101969
Merged
ericsnowcurrently added a commit that referenced this pull request Feb 17, 2023
@ericsnowcurrently
gh-101758: Fix Refleak-Related Failures in test_singlephase_variants (g…
984f8ab 
…h-101969)

gh-101891 is causing failures under `$> ./python -m test test_imp -R 3:3`.  Furthermore, with that fixed, "test_singlephase_variants" is leaking references.  This change addresses the first part, but skips the leaking tests until we can follow up with a fix.

#101758
@gpshead

gpshead commented Feb 17, 2023

Copy link
Copy Markdown
Member

!buildbot Fedora Stable Refleaks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Feb 17, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b7bf588 🤖

The command will test the builders whose names match following regular expression: Fedora Stable Refleaks

The builders matched are:
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
@bedevere-bot

bedevere-bot commented Feb 17, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b7bf588 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 4, 2024
Improve Testing For Importing Multiple Extension Modules From One File (and Deal With _testimportmultiple.c) #124978
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @gpshead @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.