GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-87849: Fix refleak in SEND instruction. by markshannon · Pull Request #101908 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Feb 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Handle generator (and coroutine) state in the bytecode. #87849

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Fix refleak in SEND instruction.
70d87e5
@markshannon markshannon added the skip news label Feb 14, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Feb 14, 2023
@markshannon markshannon changed the title GH-101788: Fix refleak in SEND instruction. GH-101578: Fix refleak in SEND instruction. Feb 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 14, 2023
PyErr_SetObject() behavior is strange and not as documented. #101578
Closed
@markshannon markshannon changed the title GH-101578: Fix refleak in SEND instruction. GH-87849: Fix refleak in SEND instruction. Feb 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 14, 2023
Handle generator (and coroutine) state in the bytecode. #87849
Closed
@markshannon markshannon mentioned this pull request Feb 14, 2023
GH-87849: Simplify stack effect of SEND and specialize it for generators. #101788
Merged
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 14, 2023
@bedevere-bot

bedevere-bot commented Feb 14, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 70d87e5 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 14, 2023
erlend-aasland
erlend-aasland approved these changes Feb 14, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 14, 2023
@erlend-aasland

erlend-aasland commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

CI is green, good to go; thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Feb 15, 2023
gh-99108: Refactor _sha256 & _sha512 into _sha2. #101924
Merged
@markshannon
markshannon merged commit c776624 into python:main Feb 15, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 15, 2023
@markshannon
markshannon deleted the fix-refleak-send branch September 26, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @bedevere-bot @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.