GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-87849: Simplify stack effect of SEND and specialize it for generators. by markshannon · Pull Request #101788 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Feb 10, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This avoids most the overhead when transferring control from caller to the generator or coroutine in a yield from or await.

The benchmarks results are in the noise, except for the "generators" benchmark which is 2.5x faster.

Mean speedup is about 1%, although that might not be meaningful if one benchmark is 150% faster.

https://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20230210-3.12.0a5%2B-685d559/bm-20230210-linux-x86_64-faster%252dcpython-specialized_send-3.12.0a5%2B-685d559-vs-base.md

  • Issue: Handle generator (and coroutine) state in the bytecode. #87849

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 reacted with rocket emoji
All reactions
  • 🚀 1 reaction
markshannon added 5 commits February 10, 2023 11:41
@markshannon
Leave receiver on stack when exiting SEND loop.
f2dbcf9
@markshannon
Specialize SEND for generators and coroutines.
685d559
@markshannon
Fix stats gathering
a2c1606
@markshannon
Add news
eaa4be1
@markshannon
Update magic number.
77dd329
@markshannon
markshannon requested a review from iritkatriel as a code owner February 10, 2023 16:32
@bedevere-bot bedevere-bot added the awaiting core review label Feb 10, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 10, 2023
Handle generator (and coroutine) state in the bytecode. #87849
Closed
@markshannon
Fix formatting.
62008ea
iritkatriel
iritkatriel approved these changes Feb 13, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 13, 2023
@markshannon
markshannon merged commit 160f2fe into python:main Feb 13, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 13, 2023
carljm added a commit to carljm/cpython that referenced this pull request Feb 13, 2023
@carljm
Merge branch 'main' into inlinecomp2
ae0bd02 
* main:
  pythongh-101810: Remove duplicated st_ino calculation (pythonGH-101811)
  pythongh-92547: Purge sqlite3_enable_shared_cache() detection from configure (python#101873)
  pythonGH-100987: Refactor `_PyInterpreterFrame` a bit, to assist generator improvement. (pythonGH-100988)
  pythonGH-87849: Simplify stack effect of SEND and specialize it for generators and coroutines. (pythonGH-101788)
  Correct trivial grammar in reset_mock docs (python#101861)
  pythongh-101845: pyspecific: Fix i18n for availability directive (pythonGH-101846)
  pythongh-89792: Limit test_tools freeze test build parallelism based on the number of cores (python#101841)
  pythongh-85984: Utilize new "winsize" functions from termios in pty tests. (python#101831)
  pythongh-89792: Prevent test_tools from copying 1000M of "source" in freeze test (python#101837)
  Fix typo in test_fstring.py (python#101823)
  pythonGH-101797: allocate `PyExpat_CAPI` capsule on heap (python#101798)
  pythongh-101390: Fix docs for `imporlib.util.LazyLoader.factory` to properly call it a class method (pythonGH-101391)
@erlend-aasland

erlend-aasland commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

FYI: I'm getting a refleak on main for ./python -m test -R : test_capi. Bisecting, it points to this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Feb 14, 2023

Copy link
Copy Markdown
Member Author

#101908
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon deleted the specialized-send branch September 26, 2023 12:50
@corona10 corona10 mentioned this pull request Oct 20, 2025
gh-140205: Add a description of SEND_GEN to the dis module. #140372
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @erlend-aasland @iritkatriel @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.