GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-72249: Include the module name in the repr of partial object by furkanonder · Pull Request #101910 · python/cpython

Conversation

furkanonder commented Feb 14, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Streamline repr(partial object) #72249

Co-authored-by: Anilyka Barry

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Include the module name in the repr of functool

ce00bbd

furkanonder requested a review from rhettinger as a code owner

February 14, 2023 16:42

bedevere-bot added the awaiting review label

Feb 14, 2023

furkanonder changed the title ~~Include the module name in the repr of functool~~ GH-72249: Include the module name in the repr of functool

Feb 14, 2023

bedevere-bot mentioned this pull request

Feb 14, 2023

Streamline repr(partial object) #72249

Closed

furkanonder changed the title ~~GH-72249: Include the module name in the repr of functool~~ GH-72249: Include the module name in the repr of partial object

Feb 14, 2023

blurb-it Bot and others added 2 commits

February 14, 2023 17:20


          📜🤖 Added by blurb_it.

313f4a2


          Merge branch 'main' into issue-72249

0457cc7

rhettinger removed their request for review

February 15, 2023 03:33

arhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label

Feb 15, 2023


          Mention the authors

a224851

furkanonder changed the title ~~GH-72249: Include the module name in the repr of partial object~~ gh-72249: Include the module name in the repr of partial object

Aug 6, 2023

serhiy-storchaka reviewed

Feb 17, 2024

View reviewed changes

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka reviewed

Feb 17, 2024

View reviewed changes

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

furkanonder added 6 commits

February 19, 2024 01:08


          Merge branch 'main' into issue-72249

6c98069


          Merge branch 'main' into issue-72249

dbd79c9


          update the news entry

4551a42


          remove _partial_types check in testcases

aacf90d


          use PyType_GetQualName and _PyType_GetModuleName functions to match t…

902e690

…he repr of python code


          Merge branch 'main' into issue-72249

930928e

serhiy-storchaka reviewed

Feb 20, 2024

View reviewed changes

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

furkanonder added 2 commits

February 25, 2024 01:44


          Check return value of _PyType_GetModuleName

810b5ca


          Merge branch 'main' into issue-72249

f79ce5e

serhiy-storchaka reviewed

Feb 24, 2024

View reviewed changes

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

sobolevn reviewed

Feb 25, 2024

View reviewed changes

Comment thread

Lib/functools.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

furkanonder and others added 3 commits

February 25, 2024 21:07


          reduce the type(self) usage in __repr__

3777e81

Co-authored-by: Nikita Sobolev <[email protected]>


          Don't handle the partial's repr without __module__

5369fad


          Merge branch 'issue-72249' of github.com:furkanonder/cpython into iss…

ef9ea5c

…ue-72249

serhiy-storchaka reviewed

Feb 25, 2024

View reviewed changes

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          call Py_ReprLeave

52390d3

serhiy-storchaka reviewed

Feb 25, 2024

View reviewed changes

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka reviewed

Feb 25, 2024

View reviewed changes

Comment thread

Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

furkanonder added 2 commits

February 25, 2024 22:45


          Remove else clause

e2174aa


          Use %S as conversion specifier for module

serhiy-storchaka approved these changes

Feb 25, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Feb 25, 2024

serhiy-storchaka merged commit 8f5be78 into python:main

Feb 25, 2024

bedevere-app Bot removed the awaiting merge label

Feb 25, 2024

Vgr255 commented Feb 25, 2024

Copy link

Copy Markdown

Contributor

Thank you @furkanonder for this! I haven't been active in CPython in years, appreciate the continued work.

furkanonder reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

furkanonder commented Feb 25, 2024

Copy link

Copy Markdown

Contributor Author

@serhiy-storchaka Thank you so much for your feedback, patience (sometimes explaining my mistakes over and over again), and time. I'd want to thank you again for providing me with the opportunity to better understand the CPython code-base.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

furkanonder commented Feb 25, 2024

Copy link

Copy Markdown

Contributor Author

Thank you @furkanonder for this! I haven't been active in CPython in years, appreciate the continued work.

You are welcome!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request

Mar 4, 2024


          pythongh-72249: Include the module name in the repr of partial object (…

04d8551

…pythonGH-101910)

Co-authored-by: Anilyka Barry <[email protected]>

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 25, 2024


          pythongh-72249: Include the module name in the repr of partial object (…

c90c72a

…pythonGH-101910)

Co-authored-by: Anilyka Barry <[email protected]>

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request

Apr 17, 2024


          pythongh-72249: Include the module name in the repr of partial object (…

f193ce8

…pythonGH-101910)

Co-authored-by: Anilyka Barry <[email protected]>

LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request

Jan 22, 2025


          pythongh-72249: Include the module name in the repr of partial object (…

3d93703

…pythonGH-101910)

Co-authored-by: Anilyka Barry <[email protected]>

zware added a commit to zware/cpython that referenced this pull request

Sep 3, 2025


          pythongh-72249: Correct wording of pythonGH-101910 blurb

504eae4

zware added a commit that referenced this pull request

Sep 3, 2025


          gh-72249: Correct wording of GH-101910 blurb (GH-138468)

007bc5f

This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 3, 2025


          pythongh-72249: Correct wording of pythonGH-101910 blurb (pythonGH-13…

9195d57

…8468)

This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.
(cherry picked from commit 007bc5f)

Co-authored-by: Zachary Ware <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 3, 2025


          pythongh-72249: Correct wording of pythonGH-101910 blurb (pythonGH-13…

07a32be

…8468)

This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.
(cherry picked from commit 007bc5f)

Co-authored-by: Zachary Ware <[email protected]>

zware pushed a commit that referenced this pull request

Sep 3, 2025


          [3.13] gh-72249: Correct wording of GH-101910 blurb (GH-138471)

e8280e3

This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.

(cherry picked from commit 007bc5f)

hugovk pushed a commit that referenced this pull request

Sep 3, 2025


          [3.14] gh-72249: Correct wording of GH-101910 blurb (GH-138468) (#138470

45a79b4

)

Co-authored-by: Zachary Ware <[email protected]>

kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request

Sep 9, 2025


          [3.14] pythongh-72249: Correct wording of pythonGH-101910 blurb (pyth…

a698b08

…onGH-138468) (python#138470)

Co-authored-by: Zachary Ware <[email protected]>

lkollar pushed a commit to lkollar/cpython that referenced this pull request

Sep 9, 2025


          pythongh-72249: Correct wording of pythonGH-101910 blurb (pythonGH-13…

24068c8

…8468)

This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.

Reviewers

sobolevn

sobolevn left review comments

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core

(Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

furkanonder commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Vgr255 commented Feb 25, 2024

Uh oh!

furkanonder commented Feb 25, 2024

Uh oh!

furkanonder commented Feb 25, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

furkanonder commented Feb 14, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.