GeezerVison

Hmm, larger question than this PR, but if this has had a syntax error for the last three years, is it still useful?

@hauntsaninja good idea! I went trough all files in c-analyzer and:

• Removed empty ones
• Removed ones that are unused (like _dparse, _alt, _state_machine)
• Removed unused imports
• Removed unused variables

I double checked that:

• It does not affect semantics
• It does not affect runtime

To test that everyting is still working I've triggered 3dc3bd9 with a partial revert of #101657 to test the warning.

However, right now Lib/test/test_check_c_globals.py is disabled :(

Any idea - why patchcheck fails?

@sobolevn It wants you to apply this diff:

diff --git a/Tools/c-analyzer/cpython/_capi.py b/Tools/c-analyzer/cpython/_capi.py
index 5584677dae..dc453cb828 100644
--- a/Tools/c-analyzer/cpython/_capi.py
+++ b/Tools/c-analyzer/cpython/_capi.py
@@ -611,7 +611,7 @@ def _render_item_full(item, groupby, verbose):
     yield f'  {"filename:":10} {item.relfile}'
     for extra in ('kind', 'level'):
         #if groupby != extra:
-            yield f'  {extra+":":10} {getattr(item, extra)}'
+        yield f'  {extra+":":10} {getattr(item, extra)}'
     if verbose:
         print('  ---------------------------------------')
         for lno, line in enumerate(item.text, item.lno):

Thank you!

I'm hesitant to do any significant cleanup on this tool before we've re-enabled the CI check for globals. Would you mind if we tabled this until then?

Sure, seems reasonable!

Since #102506 was merged, I think we can return to this PR.

Re-running the CI.

@ericsnowcurrently the CI passed with your new changes. What are the next steps?

Thanks everyone!

Is there anything else I need to do? :)
If not, can someone please click "merge"?

Thanks again, @sobolevn!