GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-88233: zipfile: refactor _strip_extra by jaraco · Pull Request #102084 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Feb 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

While reviewing #96161, I too had difficulty fully understanding the complexities of _strip_extra function.

This PR refactors that function to use a class with methods separating the concerns (parsing, splitting, filtering, modeling) and using a higher-level abstraction to model the concept.

  • Issue: Zipfile lib overwrites the extra field during closing when the archive size is more then ZIP64_LIMIT #88233

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Feb 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 20, 2023
Zipfile lib overwrites the extra field during closing when the archive size is more then ZIP64_LIMIT #88233
Closed
@jaraco
jaraco force-pushed the refactor/zipfile-extra branch from 13f4fad to 6ebff4a Compare February 20, 2023 16:57
jaraco added 3 commits February 20, 2023 12:09
@jaraco
Refactor zipfile._strip_extra to use higher level abstractions for ex…
de2802b
…tras instead of a heavy-state loop.
@jaraco
Add blurb
796f1dd
@jaraco
Remove _strip_extra and use _Extra.strip directly.
e6abc55
@jaraco
jaraco force-pushed the refactor/zipfile-extra branch from 6e57d1f to e6abc55 Compare February 20, 2023 17:10
jaraco
jaraco commented Feb 25, 2023
View reviewed changes
Comment thread Lib/zipfile/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@jaraco
Merge branch 'main' into refactor/zipfile-extra
1b4bb55
@jaraco
jaraco requested a review from serhiy-storchaka July 14, 2023 16:40
@jaraco

jaraco commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

@serhiy-storchaka If you don't mind, would you take a look at this refactor - see if you have any concerns?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jaraco
Use memoryview to avoid unnecessary copies while splitting Extras.
980ae60
@jaraco
jaraco merged commit e9791ba into python:main Sep 25, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 25, 2023
@jaraco
jaraco deleted the refactor/zipfile-extra branch September 25, 2023 23:47
@bedevere-bot

bedevere-bot commented Sep 25, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD 3.x has failed when building commit e9791ba.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1223/builds/222) and take a look at the build logs.
  4. Check if the failure is related to this commit (e9791ba) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1223/builds/222

Failed tests:

  • test.test_concurrent_futures.test_shutdown

Failed subtests:

  • test_cancel_futures_wait_false - test.test_concurrent_futures.test_shutdown.ThreadPoolShutdownTest.test_cancel_futures_wait_false

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_concurrent_futures/test_shutdown.py", line 250, in test_cancel_futures_wait_false
    self.assertEqual(out.strip(), b"apple")
AssertionError: b'' != b'apple'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@jaraco @csm10495
pythongh-88233: zipfile: refactor _strip_extra (python#102084)
b3ee6d0
* Refactor zipfile._strip_extra to use higher level abstractions for extras instead of a heavy-state loop.

* Add blurb

* Remove _strip_extra and use _Extra.strip directly.

* Use memoryview to avoid unnecessary copies while splitting Extras.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@jaraco @Glyphack
pythongh-88233: zipfile: refactor _strip_extra (python#102084)
9e459a1
* Refactor zipfile._strip_extra to use higher level abstractions for extras instead of a heavy-state loop.

* Add blurb

* Remove _strip_extra and use _Extra.strip directly.

* Use memoryview to avoid unnecessary copies while splitting Extras.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jaraco @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.