GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101981: Consolidate macOS configure steps in CI by erlend-aasland · Pull Request #102131 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: CI: intermittent macOS failures for make checksharedmods #101981

Automerge-Triggered-By: GH:erlend-aasland

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-101981: Consolidate macOS configure steps in CI
6f0f33d
@erlend-aasland
erlend-aasland requested a review from ezio-melotti as a code owner February 21, 2023 22:57
@erlend-aasland
erlend-aasland requested a review from ned-deily February 21, 2023 22:57
@bedevere-bot bedevere-bot added the awaiting core review label Feb 21, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 21, 2023
CI: intermittent macOS failures for make checksharedmods #101981
Closed
@erlend-aasland erlend-aasland added skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 21, 2023
@erlend-aasland erlend-aasland mentioned this pull request Feb 21, 2023
gh-101981: Build macOS as recommended by the devguide #102070
Merged
ned-deily
ned-deily approved these changes Feb 21, 2023
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Let's see if it works :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 21, 2023
@erlend-aasland
Fixup PKG_CONFIG_PATH to strictly follow the devguide
d38885a
@erlend-aasland

erlend-aasland commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, thanks! Let's see if it works :)

Thanks for the heads-up, I had forgotten about this :)

Now, I also adjusted the PKG_CONFIG_PATH variable to adhere to the recommendations of the devguide. We'll see how that fares.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

I'll have to look at the CI failure tomorrow; over and out from Scandinavia.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Feb 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It doesn't works and this is not the temproal issue.
it seems like test_toolsreference the GITHUB_ENV, so if we want to make this pass.
IMHO, we should make test_tools to reference the configure scope variable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland marked this pull request as draft February 22, 2023 19:33
@erlend-aasland erlend-aasland mentioned this pull request Feb 22, 2023
test_freeze_simple_script in test_tools fails to fetch CONFIG_ARGS #102151
Closed
@erlend-aasland

erlend-aasland commented Feb 22, 2023

Copy link
Copy Markdown
Contributor Author

See fix in #102152
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Merge branch 'main' into fixup-macos-build-again
37704ad
@erlend-aasland
erlend-aasland marked this pull request as ready for review February 23, 2023 14:34
@erlend-aasland erlend-aasland added the 🤖 automerge label Feb 23, 2023
@miss-islington

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit e07b304 into python:main Feb 23, 2023
@miss-islington

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 23, 2023
@bedevere-bot

bedevere-bot commented Feb 23, 2023

Copy link
Copy Markdown

GH-102177 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2023
@erlend-aasland @miss-islington
pythongh-101981: Consolidate macOS configure steps in CI (pythonGH-10…
0bf7fe6 
…2131)

(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <[email protected]>
Automerge-Triggered-By: GH:erlend-aasland
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 23, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2023
@erlend-aasland @miss-islington
pythongh-101981: Consolidate macOS configure steps in CI (pythonGH-10…
4bbb8c7 
…2131)

(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <[email protected]>
Automerge-Triggered-By: GH:erlend-aasland
@bedevere-bot

bedevere-bot commented Feb 23, 2023

Copy link
Copy Markdown

GH-102178 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Feb 23, 2023
@erlend-aasland
erlend-aasland deleted the fixup-macos-build-again branch February 23, 2023 17:11
miss-islington added a commit that referenced this pull request Feb 23, 2023
@miss-islington @erlend-aasland
gh-101981: Consolidate macOS configure steps in CI (GH-102131)
5e1bbb5 
(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <[email protected]>
Automerge-Triggered-By: GH:erlend-aasland
miss-islington added a commit that referenced this pull request Feb 23, 2023
@miss-islington @erlend-aasland
gh-101981: Consolidate macOS configure steps in CI (GH-102131)
9a0116d 
(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <[email protected]>
Automerge-Triggered-By: GH:erlend-aasland
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@erlend-aasland @JelleZijlstra
pythongh-101981: Consolidate macOS configure steps in CI (pythonGH-10…
19b5e22 
…2131)

Automerge-Triggered-By: GH:erlend-aasland
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @corona10 @miss-islington @bedevere-bot @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.