GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93649: Split exception tests from _testcapimodule.c by erlend-aasland · Pull Request #102173 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Split up _testcapimodule.c #93649

Automerge-Triggered-By: GH:erlend-aasland

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-93649: Split exception tests from _testcapimodule.c
41685d7
@erlend-aasland
erlend-aasland requested a review from iritkatriel February 23, 2023 13:27
@bedevere-bot bedevere-bot added the awaiting core review label Feb 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 23, 2023
Split up _testcapimodule.c #93649
Open
@erlend-aasland erlend-aasland added the skip news label Feb 23, 2023
@erlend-aasland

erlend-aasland commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the _testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Feb 23, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 23, 2023
@iritkatriel

iritkatriel commented Feb 23, 2023

Copy link
Copy Markdown
Member

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the _testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?

It depends, we'd need to see why it's scattered like that. Could be divided on some other criteria.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Fix windows build
a26159f
@erlend-aasland
erlend-aasland requested a review from a team as a code owner February 23, 2023 13:35
@erlend-aasland erlend-aasland added the 🤖 automerge label Feb 23, 2023
@miss-islington

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 2 commits February 23, 2023 15:07
@erlend-aasland
Pull in main
62fc7d7
@erlend-aasland
Make patchcheck happy
bf134c8
@miss-islington

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit efc985a into python:main Feb 23, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 23, 2023
@erlend-aasland
erlend-aasland deleted the split-testcapi/exceptions branch February 23, 2023 17:12
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@erlend-aasland @JelleZijlstra
pythongh-93649: Split exception tests from _testcapimodule.c (pythonG…
2131bed 
…H-102173)

Automerge-Triggered-By: GH:erlend-aasland
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @iritkatriel @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.