GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99108: Followup fix for Modules/Setup by msprotz · Pull Request #102183 · python/cpython

Conversation

@msprotz

@msprotz msprotz commented Feb 23, 2023 •
edited by erlend-aasland
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Replace built-in hashlib with verified implementations from HACL* #99108

Automerge-Triggered-By: GH:erlend-aasland

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@msprotz
msprotz requested review from a team, corona10, erlend-aasland and tiran as code owners February 23, 2023 16:49
@bedevere-bot bedevere-bot added the awaiting review label Feb 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 23, 2023
Replace built-in hashlib with verified implementations from HACL* #99108
Closed
@msprotz
Fix typo reported by @asottile
db3ae84
@msprotz
msprotz force-pushed the protz_md5_sha1 branch from 11579fc to db3ae84 Compare February 23, 2023 16:50
@msprotz msprotz mentioned this pull request Feb 23, 2023
gh-99108: Import MD5 and SHA1 from HACL* #102089
Merged
asottile
asottile approved these changes Feb 23, 2023
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea why the cpython suite doesn't fail -- my guess is it doesn't use this file

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Feb 23, 2023
@msprotz

msprotz commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

thanks -- do you mind adding a skip-news label, too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware zware added the skip news label Feb 23, 2023
@erlend-aasland

erlend-aasland commented Feb 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Can you please fix Modules/Setup.stdlib.in also?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile

asottile commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

Can you please fix Modules/Setup.stdlib.in also?

afaict that file is correct (and validated because it gets used by the testsuite)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Feb 23, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 23, 2023
@erlend-aasland erlend-aasland added the 🤖 automerge label Feb 23, 2023
@miss-islington

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit d43c265 into python:main Feb 23, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 23, 2023
@gpshead

gpshead commented Feb 23, 2023

Copy link
Copy Markdown
Member

I personally don't know why Modules/Setup even exists anymore, I thought the .in file template replaced it.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msprotz
msprotz deleted the protz_md5_sha1 branch February 23, 2023 22:49
@erlend-aasland

erlend-aasland commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

I personally don't know why Modules/Setup even exists anymore, I thought the .in file template replaced it.

Yes, true. I'm not sure if Modules/Setup is actually usable. If it is unusable, we should just tear it out.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@msprotz @JelleZijlstra
pythongh-99108: Followup fix for Modules/Setup (pythonGH-102183)
02473a9 
Automerge-Triggered-By: GH:erlend-aasland
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@tiran tiran Awaiting requested review from tiran
@corona10 corona10 Awaiting requested review from corona10
+1 more reviewer
@asottile asottile asottile approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@msprotz @erlend-aasland @asottile @miss-islington @gpshead @zware @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.