GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] gh-101981: Build macOS as recommended by the devguide (GH-102070) by erlend-aasland · Pull Request #102186 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Automerge-Triggered-By: GH:erlend-aasland.
(cherry picked from commit 2713631)

  • Issue: CI: intermittent macOS failures for make checksharedmods #101981

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
[3.9] pythongh-101981: Build macOS as recommended by the devguide (py…
6f1e95b 
…thonGH-102070)

Automerge-Triggered-By: GH:erlend-aasland.
(cherry picked from commit 2713631)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland
erlend-aasland requested a review from ned-deily February 23, 2023 21:05
@bedevere-bot bedevere-bot added the awaiting core review label Feb 23, 2023
This was referenced Feb 23, 2023
CI: intermittent macOS failures for make checksharedmods #101981
Closed
gh-101981: Build macOS as recommended by the devguide #102070
Merged
@bedevere-bot bedevere-bot added the skip news label Feb 23, 2023
@erlend-aasland
erlend-aasland requested a review from ambv February 23, 2023 21:11
@ned-deily

ned-deily commented Feb 26, 2023

Copy link
Copy Markdown
Member

I was mystified why this change now seems to work for 3.9 after the lengthy testing and discussion here shows that it shouldn't. But further investigation shows that, just 3 days ago, Homebrew made a change to their tcl-tk formula so that their Tcl/Tk is no longer "keg-only", meaning it is now linked into their normal install locations and, thus, the non-functional (as explained in the link) PKG_CONFIG_PATH addition is no longer needed with this latest Homebrew update! Great timing. We should re-examine the devguide directions and this change in that light. I'll think about it.
CAM-Gerlach, erlend-aasland, and OTheDev reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily ned-deily added the DO-NOT-MERGE label Feb 26, 2023
@ned-deily ned-deily mentioned this pull request Feb 26, 2023
Use targeted env vars for overriding compiler/linker args on macOS python/devguide#1058
Merged
@erlend-aasland erlend-aasland mentioned this pull request Feb 27, 2023
macOS build instructions depend on Homebrew specific configuration python/devguide#1059
Closed
@erlend-aasland erlend-aasland closed this Mar 10, 2023
@erlend-aasland
erlend-aasland deleted the backport-2713631-3.9 branch March 10, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily Awaiting requested review from ned-deily
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @ned-deily @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.