GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — Use targeted env vars for overriding compiler/linker args on macOS by erlend-aasland · Pull Request #1058 · python/devguide Conversation
CAM-Gerlach
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FWIW, this looks good from a docs perspective—ultimately up to the subject matter experts (Ned, etc) of course.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
ezio-melotti
reviewed
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland
marked this pull request as draft
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
@ned-deily, have you had the chance to think about this issue? IMO, it is unfortunate that we rely on Homebrew specifics. Perhaps the best thing to do, is to update the devguide recommendations for how to install the dependencies: $ brew install pkg-config [email protected] xz gdbm tcl-tk $ brew link tcl-tk # <= may produce a warning if already linked We can then carry on with this PR (and also update the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That could be an option. There are a number of other side issues with some of the other dependencies, like which ones should we use from the operating system, and there are the Homebrew differences between Intel and Apple Silicon installations. Alas, I am away right now but will get back to this in a couple of weeks. If you think there is a need to update the guide sooner, we can always tweak it again later. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
No, there's no hurry 🙂 If you're coming to SLC, we can discuss it there. If not, let's pick it up when you're ready. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@ned-deily, let's land this. We can handle the OpenSSL version in a follow-up PR (python/cpython#99079 (comment)) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Use targeted env vars for macOS build instructions
There was an error while loading. Please reload this page.