GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use targeted env vars for overriding compiler/linker args on macOS by erlend-aasland · Pull Request #1058 · python/devguide

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
Use targeted env vars for overriding compiler/linker args on macOS
7560c37
@erlend-aasland
erlend-aasland requested a review from ned-deily February 22, 2023 21:21
@erlend-aasland erlend-aasland linked an issue Feb 22, 2023 that may be closed by this pull request
Use targeted env vars for macOS build instructions #1057
Closed
@erlend-aasland
Also override lzma -l flag
a8b2620
CAM-Gerlach
CAM-Gerlach reviewed Feb 23, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this looks good from a docs perspective—ultimately up to the subject matter experts (Ned, etc) of course.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ned-deily

ned-deily commented Feb 26, 2023

Copy link
Copy Markdown
Member

I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon.

CAM-Gerlach and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily ned-deily added the DO-NOT-MERGE Do not merge this PR label Feb 26, 2023
@erlend-aasland

erlend-aasland commented Feb 27, 2023

Copy link
Copy Markdown
Contributor Author

I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon.

Ouch, it's unfortunate that our build instructions are so dependent on Homebrew distribution specifics. Let's create a separate issue for this (unless you already did so).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland mentioned this pull request Feb 27, 2023
macOS build instructions depend on Homebrew specific configuration #1059
Closed
ezio-melotti
ezio-melotti reviewed Mar 5, 2023
View reviewed changes
Comment thread getting-started/setup-building.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland marked this pull request as draft March 10, 2023 11:27
@erlend-aasland

erlend-aasland commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

As noted python/cpython#102186 (comment), we should re-think this a bit in that light. I'll have some more thoughts on it soon.

I've marked this as a draft until the above has landed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Mar 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon.

@ned-deily, have you had the chance to think about this issue? IMO, it is unfortunate that we rely on Homebrew specifics. Perhaps the best thing to do, is to update the devguide recommendations for how to install the dependencies:

$ brew install pkg-config [email protected] xz gdbm tcl-tk
$ brew link tcl-tk  # <= may produce a warning if already linked

We can then carry on with this PR (and also update the devguide build steps again).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily

ned-deily commented Mar 28, 2023

Copy link
Copy Markdown
Member

@ned-deily, have you had the chance to think about this issue? IMO, it is unfortunate that we rely on Homebrew specifics. Perhaps the best thing to do, is to update the devguide recommendations for how to install the dependencies:

That could be an option. There are a number of other side issues with some of the other dependencies, like which ones should we use from the operating system, and there are the Homebrew differences between Intel and Apple Silicon installations. Alas, I am away right now but will get back to this in a couple of weeks. If you think there is a need to update the guide sooner, we can always tweak it again later.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Mar 28, 2023

Copy link
Copy Markdown
Contributor Author

No, there's no hurry 🙂 If you're coming to SLC, we can discuss it there. If not, let's pick it up when you're ready.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily
ned-deily requested changes Apr 18, 2023
View reviewed changes
Comment thread getting-started/setup-building.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily ned-deily mentioned this pull request Jun 8, 2023
Use OpenSSL 3.0.x in our binary builds python/cpython#99079
Closed
erlend-aasland added 3 commits June 8, 2023 21:48
@erlend-aasland
Pull in main
2f22e85
@erlend-aasland
Update according to Ned's recommendations on pythongh-1058
aaaa082
@erlend-aasland
Sphinx failed to fetch links from other page
9b5920b
@erlend-aasland
erlend-aasland marked this pull request as ready for review June 8, 2023 20:35
@erlend-aasland

erlend-aasland commented Jun 8, 2023

Copy link
Copy Markdown
Contributor Author

@ned-deily, let's land this. We can handle the OpenSSL version in a follow-up PR (python/cpython#99079 (comment))

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland requested a review from ned-deily June 8, 2023 20:37
ned-deily
ned-deily approved these changes Jun 8, 2023
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@erlend-aasland
erlend-aasland merged commit b3e561c into python:main Jun 8, 2023
@erlend-aasland
erlend-aasland deleted the macos-build branch June 8, 2023 21:47
This was referenced Jun 8, 2023
CI: Configure macOS build as per updated devguide recommendations python/cpython#105533
Merged
Update macOS build recommendations to use OpenSSL 3.0 #1111
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 22, 2023
Building with OpenSSL 3.0 for the GitHub Release binaries astral-sh/python-build-standalone#175
Closed
@vitahoang vitahoang mentioned this pull request Jul 14, 2023
Python 3.10.11 macOS: tk.h version (8.5) doesn't match libtk.a version (8.6) actions/setup-python#649
Closed
2 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments
@ezio-melotti ezio-melotti ezio-melotti left review comments
@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

DO-NOT-MERGE Do not merge this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use targeted env vars for macOS build instructions

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @ned-deily @CAM-Gerlach @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.