GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Modules/) by iritkatriel · Pull Request #102196 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Feb 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This includes most of the PyErr_Fetch in Modules/. I left out a few which are a little more complicated.

  • Issue: Replace Fetch/Restore etc by the new exception APIs #102192

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 18 commits February 23, 2023 23:28
@iritkatriel
Modules/signalmodule.c
ca94282
@iritkatriel
Modules/socketmodule.c
6271ef2
@iritkatriel
Modules/_sqlite/cursor.c
05c1448
@iritkatriel
Modules/_zoneinfo.c
0bda502
@iritkatriel
Modules/_sqlite/connection.c
c7ce7f6
@iritkatriel
Modules/_xxinterpchannelsmodule.c
f0d6478
@iritkatriel
Modules/posixmodule.c
e6e1fea
@iritkatriel
Modules/_lsprof.c
3cb6039
@iritkatriel
Modules/_io/_iomodule.c
0653e47
@iritkatriel
Modules/_io/iobase.c
1bb5954
@iritkatriel
Modules/_asynciomodule.c
0c93e72
@iritkatriel
Modules/_io/bufferedio.c
c1f1f49
@iritkatriel
Modules/_io/fileio.c
6157ce8
@iritkatriel
Modules/_io/textio.c
05b2833
@iritkatriel
Modules/_io/winconsoleio.c
15e3964
@iritkatriel
Modules/_testcapi/heaptype.c
3064f2d
@iritkatriel
Modules/_testcapi/watchers.c
a160b6a
@iritkatriel
Modules/_testcapimodule.c
04985db
@iritkatriel
iritkatriel requested review from 1st1, asvetlov, berkerpeksag, erlend-aasland, gvanrossum and kumaraditya303 as code owners February 24, 2023 00:48
@bedevere-bot bedevere-bot added the awaiting core review label Feb 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 24, 2023
Replace Fetch/Restore etc by the new exception APIs #102192
Closed
erlend-aasland
erlend-aasland approved these changes Feb 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 24, 2023
@iritkatriel iritkatriel added the skip news label Feb 24, 2023
@iritkatriel
Merge branch 'main' into fetch-restore-modules
6798b05
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@bedevere-bot

bedevere-bot commented Feb 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 04985db 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@bedevere-bot

bedevere-bot commented Feb 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 6798b05 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@iritkatriel
Merge branch 'main' into fetch-restore-modules
0ed7ef3
kumaraditya303
kumaraditya303 approved these changes Feb 24, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Short on time so only reviewing asyncio changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@erlend-aasland

erlend-aasland commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

LGTM. Short on time so only reviewing asyncio changes.

FTR, I've looked over the rest.
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 2db23d1 into python:main Feb 24, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 24, 2023
@iritkatriel
iritkatriel deleted the fetch-restore-modules branch April 3, 2023 17:45
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@iritkatriel @JelleZijlstra
pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient al…
7aed8f3 
…ternatives (in Modules/) (python#102196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @bedevere-bot @erlend-aasland @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.