GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in tkinter module by iritkatriel · Pull Request #102319 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Feb 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

type and traceback are redundant now.

  • Issue: Replace Fetch/Restore etc by the new exception APIs #102192

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Feb 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 28, 2023
Replace Fetch/Restore etc by the new exception APIs #102192
Closed
@iritkatriel
iritkatriel requested review from pitrou and serhiy-storchaka February 28, 2023 10:43
@iritkatriel iritkatriel added the skip news label Feb 28, 2023
@iritkatriel
pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient al…
e68fa8b 
…ternatives in tkinter module
@iritkatriel
iritkatriel force-pushed the tkinter-exc_info branch from 06c073a to e68fa8b Compare February 28, 2023 10:47
markshannon
markshannon reviewed Feb 28, 2023
View reviewed changes
Comment thread Modules/_tkinter.c
static int quitMainLoop = 0;
static int errorInCmd = 0;
static PyObject *excInCmd;
static PyObject *valInCmd;

@markshannon markshannon Feb 28, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were unused before this PR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iritkatriel iritkatriel Feb 28, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were used in a couple of Restore() calls, scroll down.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
markshannon
markshannon approved these changes Feb 28, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 28, 2023
@pitrou

pitrou commented Feb 28, 2023

Copy link
Copy Markdown
Member

I have not followed on these new APIs, but I have no problem trusting you @iritkatriel and @markshannon :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit f91846b into python:main Mar 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 1, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Mar 29, 2023
@erlend-aasland
Purge non-existent valInCmd and trbInCmd
525897d 
Removed in python#102319
@iritkatriel
iritkatriel deleted the tkinter-exc_info branch April 3, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka
@pitrou pitrou Awaiting requested review from pitrou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @pitrou @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.