GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90997: Shrink the `LOAD_GLOBAL` caches by brandtbucher · Pull Request #102569 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Mar 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Nothing too clever here, just using 16 bits for module versions instead of 32. LOAD_GLOBAL still has no failures after this change.

Benchmarks came back very slightly negative, but I believe that's just noise (the results are being pulled down by several benchmarks known for their instability).

  • Issue: Inline bytecode caches #90997

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 8 commits February 16, 2023 15:24
@brandtbucher
Shrink the LOAD_GLOBAL caches
9931a35
@brandtbucher
Catch up with main
c8a21bd
@brandtbucher
Catch up with main
4977f1c
@brandtbucher
fixup
cf0df30
@brandtbucher
Catch up with main
7ff4fbf
@brandtbucher
Bump magic number
87449dc
@brandtbucher
fixup
0b414e2
@brandtbucher
blurb add
156c987
@brandtbucher brandtbucher added performance Performance or resource usage interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 9, 2023
@brandtbucher
brandtbucher requested a review from markshannon March 9, 2023 22:04
@brandtbucher brandtbucher self-assigned this Mar 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 9, 2023
Inline bytecode caches #90997
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 9, 2023
@brandtbucher
Fix doctest
2ef4604
@markshannon

markshannon commented Mar 10, 2023

Copy link
Copy Markdown
Member

Looks good.

We will need to change the versioning scheme to reduce the chance of the version number reaching 2**16, but it is reasonable to do this first.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon approved these changes Mar 10, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 10, 2023
@brandtbucher
brandtbucher merged commit 08b67fb into python:main Mar 11, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 11, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Mar 12, 2023
@brandtbucher @iritkatriel
pythonGH-90997: Shrink the LOAD_GLOBAL caches (python#102569)
4c8bbe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@brandtbucher @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.