GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102558: Fix AttributeError or repr() of enum member by corona10 · Pull Request #102601 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Mar 11, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: AttributeError in 3.11 on repr() of enum member if the enum has a non-Enum EnumType parent #102558

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 requested a review from ethanfurman as a code owner March 11, 2023 11:46
@bedevere-bot bedevere-bot mentioned this pull request Mar 11, 2023
AttributeError in 3.11 on repr() of enum member if the enum has a non-Enum EnumType parent #102558
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 11, 2023
@corona10 corona10 added needs backport to 3.11 only security fixes skip news and removed awaiting core review labels Mar 11, 2023
@corona10
pythongh-102558: Fix AttributeError or repr() of enum member
2136494
@corona10
corona10 force-pushed the gh-102558 branch from c05da1e to 2136494 Compare March 11, 2023 11:47
vashek
vashek reviewed Mar 11, 2023
View reviewed changes
Comment thread Lib/test/test_enum.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Fix test
ffa2048
sobolevn
sobolevn reviewed Mar 11, 2023
View reviewed changes
Comment thread Lib/test/test_enum.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_enum.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Address code review
38b083b
@corona10
corona10 force-pushed the gh-102558 branch from c94a5f6 to 38b083b Compare March 12, 2023 08:36
@vashek

vashek commented Mar 23, 2023

Copy link
Copy Markdown

Is there anything that should be done to get this reviewed and merged, or are we just waiting for @ethanfurman's attention and time? Sorry, not meaning to nag, just unfamiliar with the process here. Thanks.
ethanfurman reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ethanfurman
ethanfurman approved these changes Mar 23, 2023
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Mar 23, 2023
@ethanfurman
ethanfurman merged commit bd06375 into python:main Mar 23, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 23, 2023
@miss-islington

miss-islington commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2023
@corona10 @miss-islington
pythongh-102558: [Enum] fix AttributeError during member repr() (pyth…
9963aa7 
…onGH-102601)

(cherry picked from commit bd06375)

Co-authored-by: Dong-hee Na <[email protected]>
@bedevere-bot

bedevere-bot commented Mar 23, 2023

Copy link
Copy Markdown

GH-102977 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 23, 2023
miss-islington added a commit that referenced this pull request Mar 23, 2023
@miss-islington @corona10
gh-102558: [Enum] fix AttributeError during member repr() (GH-102601)
8132aef 
(cherry picked from commit bd06375)

Co-authored-by: Dong-hee Na <[email protected]>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@corona10 @Fidget-Spinner
pythongh-102558: [Enum] fix AttributeError during member repr() (pyth…
9227b98 
…onGH-102601)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@corona10 @warsaw
pythongh-102558: [Enum] fix AttributeError during member repr() (pyth…
0e964a8 
…onGH-102601)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments
@ethanfurman ethanfurman ethanfurman approved these changes
+1 more reviewer
@vashek vashek vashek left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@corona10 @vashek @miss-islington @bedevere-bot @sobolevn @ethanfurman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.