GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-79940: skip `TestGetAsyncGenState` on wasm as it requires working sockets by tkren · Pull Request #102605 · python/cpython

Conversation

@tkren

@tkren tkren commented Mar 11, 2023 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Skip TestGetAsyncGenState and restoring of the default event loop policy in test_inspect if platform lacks working socket support.

Fixes #11590

  • Issue: inspect module does not implement introspection API for asynchronous generators #79940

Automerge-Triggered-By: GH:kumaraditya303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 11, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 11, 2023
inspect module does not implement introspection API for asynchronous generators #79940
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 11, 2023
@tkren
tkren force-pushed the fix-pr-11590-test-inspect branch from 2c44e3b to 184f617 Compare March 11, 2023 16:15
@tkren
TestGetAsyncGenState requires working sockets
6ab6bcf 
Skip `TestGetAsyncGenState` and restoring of the default event loop
policy in `test_inspect` if platform lacks working socket support.

Fixes python#11590
@tkren
tkren force-pushed the fix-pr-11590-test-inspect branch from 184f617 to 6ab6bcf Compare March 11, 2023 16:28
@tkren

tkren commented Mar 11, 2023

Copy link
Copy Markdown
Contributor Author

@kumaraditya303 this is the follow-up PR for #11590
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

!buildbot .wasm.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 6ab6bcf 🤖

The command will test the builders whose names match following regular expression: .*wasm.*

The builders matched are:

  • wasm32-emscripten node (pthreads) PR
  • wasm32-emscripten browser (dynamic linking, no tests) PR
  • wasm32-wasi PR
  • wasm32-emscripten node (dynamic linking) PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Delete 2023-03-11-11-14-01.gh-issue-79940.UH4d3k.rst
ea7431d
kumaraditya303
kumaraditya303 approved these changes Mar 11, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we don't need news for this so I removed it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tkren reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 11, 2023
@kumaraditya303 kumaraditya303 added the skip news label Mar 11, 2023
@kumaraditya303 kumaraditya303 changed the title gh-79940: TestGetAsyncGenState requires working sockets gh-79940: skip TestGetAsyncGenState on wasm as it requires working sockets Mar 11, 2023
@kumaraditya303 kumaraditya303 added the 🤖 automerge label Mar 11, 2023
@miss-islington

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Head branch was modified. Review and try the merge again..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 534660f into python:main Mar 11, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 11, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Mar 12, 2023
@tkren @iritkatriel
pythongh-79940: skip TestGetAsyncGenState on wasm as it requires wo…
45cc601 
…rking sockets (pythonGH-102605)

Skip `TestGetAsyncGenState` and restoring of the default event loop policy in `test_inspect` if platform lacks working socket support.

Fixes python#11590

Automerge-Triggered-By: GH:kumaraditya303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tkren @kumaraditya303 @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.