GeezerVison is showing github.com — gh-100061: Restore the global Input Stream pointer by uyw4687 · Pull Request #102612 · python/cpython
Conversation
uyw4687
commented
Mar 11, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hauntsaninja
changed the title
pythongh-100061 Restore the global Input Stream pointer
gh-100061: Restore the global Input Stream pointer
Mar 11, 2023
ghost
left a comment
•
edited by ghost
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new entry that describe the fix to user.
Such as: Fix wrong match in postive qualifiers. Patch by <your name>
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
uyw4687 reacted with thumbs up emoji
|
|
self.assertIsNone(re.match("^x{}+$", "xxx"))
|
|
|
self.assertTrue(re.match("^x{}+$", "x{}"))
|
|
|
|
|
|
self.assertEqual(re.match('((.(?!C))++)', 'ABCD').span(), (0, 1))
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may add a comment # gh-100061 for this test-case.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
uyw4687
Mar 13, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
IMO the fix is fine. Just adjust some details (comment/new_entry).
Need to wait for a core developer to merge the PR.
|
uyw4687 reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @uyw4687 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry, @uyw4687 and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker abd9cc52d94b8e2835322b62c29f09bb0e6fcfe9 3.12
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry, @uyw4687 and @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker abd9cc52d94b8e2835322b62c29f09bb0e6fcfe9 3.11
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x has failed when building commit abd9cc5.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/78/builds/5080) and take a look at the build logs.
- Check if the failure is related to this commit (abd9cc5) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/all/#builders/78/builds/5080
Summary of the results of the build (if available):
== Tests result: ENV CHANGED ==
431 tests OK.
10 slowest tests:
- test_concurrent_futures: 2 min 27 sec
- test_multiprocessing_spawn: 1 min 59 sec
- test_multiprocessing_forkserver: 1 min 16 sec
- test_signal: 1 min 12 sec
- test_multiprocessing_fork: 1 min 8 sec
- test_socket: 42.6 sec
- test_io: 40.1 sec
- test_imaplib: 32.8 sec
- test_subprocess: 32.3 sec
- test_xmlrpc: 27.5 sec
1 test altered the execution environment:
test_interpreters
15 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_gdb
test_ioctl test_kqueue test_launcher test_startfile test_tkinter
test_ttk test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64
Total duration: 2 min 37 sec
Click to see traceback logs
Traceback (most recent call last):
File "<frozen importlib._bootstrap>", line 1266, in _find_and_load
File "<frozen importlib._bootstrap>", line 1237, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 841, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 999, in exec_module
File "<frozen importlib._bootstrap_external>", line 1095, in get_code
File "<frozen importlib._bootstrap_external>", line 1194, in get_data
TypeError: descriptor 'close' for '_io.BufferedReader' objects doesn't apply to a '_io.FileIO' object
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 1052, in _bootstrap_inner
self.run()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 989, in run
self._target(*self._args, **self._kwargs)
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_interpreters.py", line 481, in task
interp = interpreters.create()
^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/support/interpreters.py", line 25, in create
id = _interpreters.create(isolated=isolated)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: interpreter creation failed
k
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|