GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102582: Fix invalid JSON in Doc/howto/logging-cookbook.rst by mcepl · Pull Request #102635 · python/cpython

Conversation

@mcepl

@mcepl mcepl commented Mar 13, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Another invalid JSON in  #102582

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mcepl
mcepl requested a review from vsajip as a code owner March 13, 2023 06:55
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Mar 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 13, 2023
Another invalid JSON in #102582
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 13, 2023
@mcepl
Fix invalid JSON in Doc/howto/logging-cookbook.rst
59e12a6 
Fixes python#102582
@mcepl
mcepl force-pushed the 102582-invalid-JSON branch from 8c02ef9 to 59e12a6 Compare March 26, 2023 07:39
vsajip
vsajip approved these changes Mar 29, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 29, 2023
@vsajip
vsajip merged commit d835b3f into python:main Mar 29, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 29, 2023
@vsajip vsajip added needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 29, 2023
@miss-islington

miss-islington commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @mcepl for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @mcepl for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 29, 2023

Copy link
Copy Markdown

GH-103106 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 29, 2023
@bedevere-bot

bedevere-bot commented Mar 29, 2023

Copy link
Copy Markdown

GH-103107 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 29, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 29, 2023
@mcepl @miss-islington
pythongh-102582: Fix invalid JSON in Doc/howto/logging-cookbook.rst (p…
ad2e3f4 
…ythonGH-102635)

(cherry picked from commit d835b3f)

Co-authored-by: Matěj Cepl <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 29, 2023
@mcepl @miss-islington
pythongh-102582: Fix invalid JSON in Doc/howto/logging-cookbook.rst (p…
5527e70 
…ythonGH-102635)

(cherry picked from commit d835b3f)

Co-authored-by: Matěj Cepl <[email protected]>
vsajip pushed a commit that referenced this pull request Mar 29, 2023
@miss-islington @mcepl
[3.11] gh-102582: Fix invalid JSON in Doc/howto/logging-cookbook.rst (G…
d189e2d 
…H-102635) (GH-103106)

(cherry picked from commit d835b3f)

Co-authored-by: Matěj Cepl <[email protected]>
vsajip pushed a commit that referenced this pull request Mar 29, 2023
@miss-islington @mcepl
[3.10] gh-102582: Fix invalid JSON in Doc/howto/logging-cookbook.rst (G…
473fd7b 
…H-102635) (GH-103107)

(cherry picked from commit d835b3f)
Co-authored-by: Matěj Cepl <[email protected]>
@mcepl
mcepl deleted the 102582-invalid-JSON branch March 29, 2023 10:02
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@mcepl @warsaw
pythongh-102582: Fix invalid JSON in Doc/howto/logging-cookbook.rst (p…
417312a 
…ythonGH-102635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mcepl @miss-islington @bedevere-bot @vsajip
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.