GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98608: Stop Treating All Errors from _Py_NewInterpreterFromConfig() as Fatal by ericsnowcurrently · Pull Request #102657 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Mar 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Prior to this change, errors in _Py_NewInterpreterFromConfig() were always fatal. Instead, callers should be able to handle such errors and keep going. That's what this change supports. Note that the existing [fatal] behavior of the public Py_NewInterpreter() is preserved.

  • Issue: Expose _Py_NewInterpreter() as Py_NewInterpreterFromConfig() #98608

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ericsnowcurrently added 2 commits March 13, 2023 15:12
@ericsnowcurrently
Errors from _Py_NewInterpreterFromConfig() are no longer fatal.
60eb1d6
@ericsnowcurrently
Chain the exceptions.
217a430
@ericsnowcurrently ericsnowcurrently added the skip news label Mar 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 13, 2023
Expose _Py_NewInterpreter() as Py_NewInterpreterFromConfig() #98608
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 13, 2023
@ericsnowcurrently ericsnowcurrently mentioned this pull request Mar 13, 2023
gh-101659: Isolate "obmalloc" State to Each Interpreter #101660
Merged
@ericsnowcurrently
ericsnowcurrently merged commit 3bb4756 into python:main Mar 21, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 21, 2023
@ericsnowcurrently
ericsnowcurrently deleted the nonfatal-new-interpreter-errors branch March 21, 2023 16:49
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@ericsnowcurrently @Fidget-Spinner
pythongh-98608: Stop Treating All Errors from _Py_NewInterpreterFromC…
8eb9d2f
…onfig() as Fatal (pythongh-102657)

Prior to this change, errors in _Py_NewInterpreterFromConfig() were always fatal.  Instead, callers should be able to handle such errors and keep going.  That's what this change supports.  (This was an oversight in the original implementation of _Py_NewInterpreterFromConfig().)  Note that the existing [fatal] behavior of the public Py_NewInterpreter() is preserved.

python#98608
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@ericsnowcurrently @warsaw
pythongh-98608: Stop Treating All Errors from _Py_NewInterpreterFromC…
3d9645b
…onfig() as Fatal (pythongh-102657)

Prior to this change, errors in _Py_NewInterpreterFromConfig() were always fatal.  Instead, callers should be able to handle such errors and keep going.  That's what this change supports.  (This was an oversight in the original implementation of _Py_NewInterpreterFromConfig().)  Note that the existing [fatal] behavior of the public Py_NewInterpreter() is preserved.

python#98608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.