GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98608: Fix Failure-handling in new_interpreter() by ericsnowcurrently · Pull Request #102658 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Mar 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The error-handling code in new_interpreter() has been broken for a while. We hadn't noticed because those code mostly doesn't fail. (I noticed while working on gh-101660.) The problem is that we try to clear/delete the newly-created thread/interpreter using itself, which just failed. The solution is to switch back to the calling thread state first.

  • Issue: Expose _Py_NewInterpreter() as Py_NewInterpreterFromConfig() #98608

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Swap out the failed tstate.
099e80a
@ericsnowcurrently ericsnowcurrently added the skip news label Mar 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 13, 2023
Expose _Py_NewInterpreter() as Py_NewInterpreterFromConfig() #98608
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 13, 2023
@ericsnowcurrently ericsnowcurrently mentioned this pull request Mar 13, 2023
gh-101659: Isolate "obmalloc" State to Each Interpreter #101660
Merged
kumaraditya303
kumaraditya303 approved these changes Mar 14, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 14, 2023
@kumaraditya303

kumaraditya303 commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

Seems worth backporting to me.
ericsnowcurrently and furkanonder reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently added needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 21, 2023
@ericsnowcurrently
ericsnowcurrently merged commit d1b883b into python:main Mar 21, 2023
@miss-islington

miss-islington commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 21, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-failed-interp-creation branch March 21, 2023 18:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2023
@ericsnowcurrently @miss-islington
pythongh-98608: Fix Failure-handling in new_interpreter() (pythongh-1…
ab2a432 
…02658)

The error-handling code in new_interpreter() has been broken for a while.  We hadn't noticed because those code mostly doesn't fail.  (I noticed while working on pythongh-101660.)  The problem is that we try to clear/delete the newly-created thread/interpreter using itself, which just failed.  The solution is to switch back to the calling thread state first.

(cherry picked from commit d1b883b)

Co-authored-by: Eric Snow <[email protected]>
https: //github.com/python/issues/98608
@bedevere-bot

bedevere-bot commented Mar 21, 2023

Copy link
Copy Markdown

GH-102882 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2023
@ericsnowcurrently @miss-islington
pythongh-98608: Fix Failure-handling in new_interpreter() (pythongh-1…
4a8445d 
…02658)

The error-handling code in new_interpreter() has been broken for a while.  We hadn't noticed because those code mostly doesn't fail.  (I noticed while working on pythongh-101660.)  The problem is that we try to clear/delete the newly-created thread/interpreter using itself, which just failed.  The solution is to switch back to the calling thread state first.

(cherry picked from commit d1b883b)

Co-authored-by: Eric Snow <[email protected]>
https: //github.com/python/issues/98608
@bedevere-bot

bedevere-bot commented Mar 21, 2023

Copy link
Copy Markdown

GH-102883 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 21, 2023
miss-islington added a commit that referenced this pull request Mar 21, 2023
@miss-islington @ericsnowcurrently
gh-98608: Fix Failure-handling in new_interpreter() (gh-102658)
d5fdc3f 
The error-handling code in new_interpreter() has been broken for a while.  We hadn't noticed because those code mostly doesn't fail.  (I noticed while working on gh-101660.)  The problem is that we try to clear/delete the newly-created thread/interpreter using itself, which just failed.  The solution is to switch back to the calling thread state first.

(cherry picked from commit d1b883b)

Co-authored-by: Eric Snow <[email protected]>
https: //github.com//issues/98608
miss-islington added a commit that referenced this pull request Mar 21, 2023
@miss-islington @ericsnowcurrently
gh-98608: Fix Failure-handling in new_interpreter() (gh-102658)
4c6b354 
The error-handling code in new_interpreter() has been broken for a while.  We hadn't noticed because those code mostly doesn't fail.  (I noticed while working on gh-101660.)  The problem is that we try to clear/delete the newly-created thread/interpreter using itself, which just failed.  The solution is to switch back to the calling thread state first.

(cherry picked from commit d1b883b)

Co-authored-by: Eric Snow <[email protected]>
https: //github.com//issues/98608
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@ericsnowcurrently @Fidget-Spinner
pythongh-98608: Fix Failure-handling in new_interpreter() (pythongh-1…
ac24ffa 
…02658)

The error-handling code in new_interpreter() has been broken for a while.  We hadn't noticed because those code mostly doesn't fail.  (I noticed while working on pythongh-101660.)  The problem is that we try to clear/delete the newly-created thread/interpreter using itself, which just failed.  The solution is to switch back to the calling thread state first.

python#98608
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@ericsnowcurrently @warsaw
pythongh-98608: Fix Failure-handling in new_interpreter() (pythongh-1…
45f7d84 
…02658)

The error-handling code in new_interpreter() has been broken for a while.  We hadn't noticed because those code mostly doesn't fail.  (I noticed while working on pythongh-101660.)  The problem is that we try to clear/delete the newly-created thread/interpreter using itself, which just failed.  The solution is to switch back to the calling thread state first.

python#98608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @kumaraditya303 @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.