GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94673: Isolate the _io module to Each Interpreter by ericsnowcurrently · Pull Request #102663 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Mar 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Aside from sys and builtins, _io is the only core builtin module that hasn't been ported to multi-phase init. We may do so later, but in the meantime we must at least take care of the module's static types properly. (This came up while working on gh-101660.)

  • Issue: [subinterpreters] Static types incorrectly share some objects between interpreters #94673

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently
Add _PyIO_InitTypes().
cac2915
@ericsnowcurrently ericsnowcurrently added the skip news label Mar 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 13, 2023
[subinterpreters] Static types incorrectly share some objects between interpreters #94673
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 13, 2023
@ericsnowcurrently ericsnowcurrently mentioned this pull request Mar 13, 2023
gh-101659: Isolate "obmalloc" State to Each Interpreter #101660
Merged
@AlexWaygood

AlexWaygood commented Mar 13, 2023

Copy link
Copy Markdown
Member

X-ref'ing:

  • Isolate the _io extension module #101819
  • gh-101819: Isolate _io #101948
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericsnowcurrently added 2 commits March 21, 2023 12:39
@ericsnowcurrently
Set base types before PyType_Ready() is called.
becfac5
@ericsnowcurrently
Merge branch 'main' into isolate-io-module
6e98e96
@ericsnowcurrently
ericsnowcurrently merged commit e6ecd3e into python:main Mar 21, 2023
@ericsnowcurrently
ericsnowcurrently deleted the isolate-io-module branch March 21, 2023 20:01
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 21, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@ericsnowcurrently @Fidget-Spinner
pythongh-94673: Isolate the _io module to Each Interpreter (pythongh-…
7de1d79
…102663)

Aside from sys and builtins, _io is the only core builtin module that hasn't been ported to multi-phase init.  We may do so later (e.g. pythongh-101948), but in the meantime we must at least take care of the module's static types properly.  (This came up while working on pythongh-101660.)

python#94673
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@ericsnowcurrently @warsaw
pythongh-94673: Isolate the _io module to Each Interpreter (pythongh-…
9d7a022
…102663)

Aside from sys and builtins, _io is the only core builtin module that hasn't been ported to multi-phase init.  We may do so later (e.g. pythongh-101948), but in the meantime we must at least take care of the module's static types properly.  (This came up while working on pythongh-101660.)

python#94673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.