GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix typo in code comment by martin-martin · Pull Request #102726 · python/cpython

Conversation

@martin-martin

@martin-martin martin-martin commented Mar 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I just came across a tiny typo while doing research for an article and thought I'd note it via a PR in case it's considered worth updating. :)

Thanks for all your work!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@martin-martin
martin-martin requested a review from iritkatriel as a code owner March 15, 2023 14:00
@ghost

ghost commented Mar 15, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 15, 2023
@bedevere-bot

bedevere-bot commented Mar 15, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Mar 15, 2023
@AlexWaygood AlexWaygood added skip issue skip news labels Mar 15, 2023
AlexWaygood
AlexWaygood approved these changes Mar 15, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 15, 2023
@AlexWaygood AlexWaygood added 🤖 automerge and removed awaiting merge labels Mar 15, 2023
@martin-martin
Fix typo in code comment
0ee543b
@martin-martin
martin-martin force-pushed the patch-1 branch from 15393d2 to 0ee543b Compare March 15, 2023 15:41
@martin-martin

martin-martin commented Mar 15, 2023

Copy link
Copy Markdown
Contributor Author

Oh, I thought that a rebase would be a good idea in this situation, as there were some other merged changes before the checks here were complete.

But it looks like a test is failing now? I'm not sure why this would happen considering I rebased on main and the only change is a typo fix in a code comment.

Apologies, I didn't mean to take up too much of anyones' time with this 😬
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Mar 15, 2023

Copy link
Copy Markdown
Member

The failing test will be fixed by #102735; after that's merged, we can merge main into your branch here, and then the test will pass here and we can merge this in :)
martin-martin reacted with thumbs up emoji martin-martin reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@martin-martin

martin-martin commented Mar 15, 2023

Copy link
Copy Markdown
Contributor Author

Thank you @AlexWaygood :)
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Merge branch 'main' into patch-1
134475f
@AlexWaygood
AlexWaygood merged commit 00d1ef7 into python:main Mar 15, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@martin-martin @Fidget-Spinner
Fix typo in code comment (python#102726)
b537248
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@martin-martin @warsaw
Fix typo in code comment (python#102726)
4726341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@martin-martin @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.