GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Simplify and speed-up math.hypot() and math.dist() by rhettinger · Pull Request #102734 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Mar 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Apply the sumprod() DoubleLength functions to vector_norm() which is called by both hypot() and dist().

Baseline timing

% ./python.exe -m timeit -r11 -s 'from random import expovariate as r' -s 'from math import hypot' -s 'n=100' -s 'data = [r() for i in range(n)]' 'hypot(*data)'
500000 loops, best of 11: 579 nsec per loop

Timing with PR

% ./python.exe -m timeit -r11 -s 'from random import expovariate as r' -s 'from math import hypot' -s 'n=100' -s 'data = [r() for i in range(n)]' 'hypot(*data)'
500000 loops, best of 11: 476 nsec per loop

Timing with PR if fma() is not used

% ./python.exe -m timeit -r11 -s 'from random import expovariate as r' -s 'from math import hypot' -s 'n=100' -s 'data = [r() for i in range(n)]' 'hypot(*data)'
500000 loops, best of 11: 531 nsec per loop

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
rhettinger added 5 commits March 15, 2023 01:13
@rhettinger
Move double and triple length helper functions to the top
cd7cfc7
@rhettinger
Add more double length functions to support vector_norm
cd5fb29
@rhettinger
Use DoubleLength functions in hypot().
8f3e73c
@rhettinger
Update comments
58377df
@rhettinger
Remove unused code
47e878d
@rhettinger rhettinger added performance Performance or resource usage skip issue skip news 3.12 only security fixes labels Mar 15, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Mar 15, 2023
This was referenced Mar 15, 2023
gh-94440: Fix issue of ProcessPoolExecutor shutdown hanging #94468
Merged
Exclude ceval.c from the C-analyzer tool #102735
Merged
C-analyzer tool cannot parse #line directives #102737
Closed
@rhettinger
Merge branch 'main' into faster_hypot
9a63c70
@rhettinger
rhettinger merged commit 0a22aa0 into python:main Mar 15, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 15, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@rhettinger @Fidget-Spinner
Simplify and speed-up math.hypot() and math.dist() (pythonGH-102734)
824309e
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@rhettinger @warsaw
Simplify and speed-up math.hypot() and math.dist() (pythonGH-102734)
0c728b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12 only security fixes performance Performance or resource usage skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rhettinger @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.