GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-102778: Add sys.last_exc, deprecate sys.last_type, sys.last_value,sys.last_traceback by iritkatriel · Pull Request #102779 · python/cpython Conversation
|
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit e1cc312 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t pdb.pm() be changed to use sys.last_exc?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Yes, idlelib too. But I'm not sure whether we do that now or in 3.14 when it won't interfere with backports. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
I would do it now, but look both (in case user code sets one or the other): if sys.last_exc exists, use that, else if sys.last_(type,value,traceback) exist, use those, else fail. Then in the future we can delete the code checking for the latter. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 2ce2c26 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Please revert the changes to idlelib. (Why the rush before I could respond.) I dislike the awkward workaround changes, which IDLE does not need, and they cannot be backported. I would much prefer to make more extensive changes that get rid of nearly all references to the deprecated attributes and which can be backported. For instance, in test_stackviewer setup, replace Let me request again (from the previous PR that was closed) that idlelib changes be put in a separate PR that I can review and backport. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, will revert and fix. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
If a user tries to access sys.last_type or sys.last_traceback then it won't work. Is this not an issue? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Yes, |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…value,sys.last_traceback (python#102779)
…value,sys.last_traceback (python#102779)
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.