GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102828: fix test failure (add missing skip instructions) by iritkatriel · Pull Request #102835 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Mar 19, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I copied part of this test from test_on_exc, but I did not copy the "skip" decorators so it's failing on some buildbots.

  • Issue: add option for error callback of to shutil.rmtree to accept exception rather than exc_info #102828

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-102828: fix test failure (add missing skip instructions)
b30b375
@iritkatriel
iritkatriel requested a review from giampaolo March 19, 2023 21:11
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 19, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 19, 2023
add option for error callback of to shutil.rmtree to accept exception rather than exc_info #102828
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 19, 2023
@iritkatriel iritkatriel added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting core review labels Mar 19, 2023
@bedevere-bot

bedevere-bot commented Mar 19, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit b30b375 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 19, 2023
@iritkatriel
iritkatriel merged commit 40d4f15 into python:main Mar 20, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102828: fix test failure (add missing skip instructions) (py…
5699276 
…thon#102835)
@iritkatriel
iritkatriel deleted the fix-test branch April 3, 2023 17:42
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@iritkatriel @warsaw
pythongh-102828: fix test failure (add missing skip instructions) (py…
ae76f91 
…thon#102835)
@coderabbitai coderabbitai Bot mentioned this pull request Sep 12, 2026
ci+test(viz): hermetic viz gate on a frozen corpus; data-gated interaction pins robbe1912/neuronav#166
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giampaolo giampaolo Awaiting requested review from giampaolo giampaolo is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iritkatriel @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.