GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP by iritkatriel · Pull Request #102870 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Mar 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #102859 .

  • Issue: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP #102859

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 3 commits March 21, 2023 00:45
@iritkatriel
pythongh-102859: remove opcodes JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE…
1e63ce0 
…_OR_POP
@iritkatriel
add news
96602a0
@iritkatriel
fix peepholer
22ed3a6
@iritkatriel
iritkatriel requested review from brandtbucher and markshannon as code owners March 21, 2023 12:00
@bedevere-bot bedevere-bot mentioned this pull request Mar 21, 2023
Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP #102859
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 21, 2023
@iritkatriel iritkatriel mentioned this pull request Mar 21, 2023
Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP faster-cpython/ideas#567
Closed
@iritkatriel
Merge remote-tracking branch 'upstream/main' into remove-JUMP_IF_FALS…
08c0826 
…E_OR_POP
@iritkatriel
iritkatriel marked this pull request as draft March 21, 2023 12:24
@iritkatriel

iritkatriel commented Mar 21, 2023

Copy link
Copy Markdown
Member Author

There's still a problem with the peepholer. Converting to draft.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
fix optimizations
0097e54
@iritkatriel
iritkatriel marked this pull request as ready for review March 21, 2023 14:40
@iritkatriel
init 'target'
12595f6
carljm
carljm approved these changes Mar 21, 2023
View reviewed changes
Comment thread Python/compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 21, 2023
@iritkatriel

iritkatriel commented Mar 21, 2023

Copy link
Copy Markdown
Member Author

Thanks, I’ll wait for benchmark results before merging.
carljm reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
Merge branch 'main' into remove-JUMP_IF_FALSE_OR_POP
b2bf829
@markshannon

markshannon commented Mar 22, 2023

Copy link
Copy Markdown
Member

https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20230322-3.12.0a6+-b2bf829
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon approved these changes Mar 22, 2023
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this to cause a slowdown, but it seems the slowdown is negligible.

I expect that we will be able to get all that back and more with the optimizations discussed in the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel iritkatriel added interpreter-core (Objects, Python, Grammar, and Parser dirs) 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Mar 22, 2023
@bedevere-bot

bedevere-bot commented Mar 22, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit b2bf829 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 22, 2023
iritkatriel added 2 commits March 22, 2023 16:44
@iritkatriel
make remove_redundant_nops_and_pairs safe
ddb3003
@iritkatriel
Merge remote-tracking branch 'upstream/main' into remove-JUMP_IF_FALS…
ab2dfe1 
…E_OR_POP
@iritkatriel

iritkatriel commented Mar 22, 2023

Copy link
Copy Markdown
Member Author

refleak check passed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 3468c76 into python:main Mar 22, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 22, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP (p…
27f390b 
…ython#102870)
@iritkatriel
iritkatriel deleted the remove-JUMP_IF_FALSE_OR_POP branch April 3, 2023 17:42
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@iritkatriel @warsaw
pythongh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP (p…
3b6ada4 
…ython#102870)
@ShaharNaveh ShaharNaveh mentioned this pull request Dec 25, 2025
Reduce usage JumpIfTrueOrPop & JumpIfFalseOrPop opcdes. Refactor compile_compare RustPython/RustPython#6524
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@markshannon markshannon markshannon approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @markshannon @bedevere-bot @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.