GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102799: use exception instance instead of sys.exc_info() by iritkatriel · Pull Request #102885 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Mar 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

A few more places that can be tidied up.

  • Issue: some usages of sys.exc_info can be replaced by more modern code #102799

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-102799: use exception instance instead of exc_info
720a696
@iritkatriel
iritkatriel requested a review from vsajip as a code owner March 21, 2023 19:52
@bedevere-bot bedevere-bot mentioned this pull request Mar 21, 2023
some usages of sys.exc_info can be replaced by more modern code #102799
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 21, 2023
furkanonder
furkanonder reviewed Mar 21, 2023
View reviewed changes
Comment thread Lib/test/inspect_fodder.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added 2 commits March 21, 2023 23:03
@iritkatriel
fix test_with
2375bdb
@iritkatriel
remove unused import
be0e4b5
@iritkatriel iritkatriel added the skip news label Mar 21, 2023
furkanonder
furkanonder approved these changes Mar 22, 2023
View reviewed changes
@iritkatriel
iritkatriel requested a review from erlend-aasland March 30, 2023 16:42
erlend-aasland
erlend-aasland approved these changes Mar 31, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 31, 2023
@iritkatriel
iritkatriel merged commit 44bd3fe into python:main Mar 31, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 31, 2023
@iritkatriel
iritkatriel deleted the exc_info branch April 3, 2023 17:41
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@iritkatriel @warsaw
pythongh-102799: use exception instance instead of sys.exc_info() (py…
2f7d16a 
…thon#102885)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@furkanonder furkanonder furkanonder approved these changes
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @erlend-aasland @furkanonder @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.