GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103025: fix ctypes doc issues by peterjpxie · Pull Request #103026 · python/cpython

Conversation

@peterjpxie

@peterjpxie peterjpxie commented Mar 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

1/ Rectify typo 'varadic' functions to 'variadic'.

2/ Fix doctest directive mistake.

  • Issue: [ctypes documentation issues] varadic typo and doctest directive mistake #103025

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@peterjpxie
[ctypes doc] 1/ Rectify typo 'varadic' functions to 'variadic'. 2/ Fi…
9c5634c 
…x doctest directive mistake.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Mar 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 25, 2023
[ctypes documentation issues] varadic typo and doctest directive mistake #103025
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 25, 2023
@peterjpxie
Merge branch 'main' into fix-ctypes-doc-issues
34af2aa
@peterjpxie

peterjpxie commented Mar 25, 2023

Copy link
Copy Markdown
Contributor Author

@CAM-Gerlach pls. kindly review this PR if all checks pass. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes Mar 25, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not Cam, but looks good to me — thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
peterjpxie reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 25, 2023
@AlexWaygood AlexWaygood added needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 25, 2023
@AlexWaygood
AlexWaygood merged commit 0708437 into python:main Mar 25, 2023
@miss-islington

miss-islington commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @peterjpxie for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2023
@peterjpxie @miss-islington
pythongh-103025: fix two ctypes doc issues (pythonGH-103026)
dbf6ccc 
(cherry picked from commit 0708437)

Co-authored-by: Peter Jiping Xie <[email protected]>
@bedevere-bot

bedevere-bot commented Mar 25, 2023

Copy link
Copy Markdown

GH-103029 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2023
@peterjpxie @miss-islington
pythongh-103025: fix two ctypes doc issues (pythonGH-103026)
36cf1bc 
(cherry picked from commit 0708437)

Co-authored-by: Peter Jiping Xie <[email protected]>
@bedevere-bot

bedevere-bot commented Mar 25, 2023

Copy link
Copy Markdown

GH-103030 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 25, 2023
@bedevere-bot

This comment was marked as duplicate.

Sign in to view
@bedevere-bot

This comment was marked as duplicate.

Sign in to view
AlexWaygood pushed a commit that referenced this pull request Mar 25, 2023
@miss-islington
[3.10] gh-103025: fix a ctypes doc typo (GH-103026) (#103030)
db5bf52 
* gh-103025: fix two ctypes doc issues  (GH-103026)
(cherry picked from commit 0708437)
AlexWaygood pushed a commit that referenced this pull request Mar 25, 2023
@miss-islington @peterjpxie
[3.11] gh-103025: fix a ctypes doc typo (GH-103026) (#103029)
aae91fa 
* gh-103025: fix two ctypes doc issues  (GH-103026)
(cherry picked from commit 0708437)

Co-authored-by: Peter Jiping Xie <[email protected]>
@peterjpxie
peterjpxie deleted the fix-ctypes-doc-issues branch March 25, 2023 11:02
@CAM-Gerlach

CAM-Gerlach commented Mar 25, 2023

Copy link
Copy Markdown
Member

Thanks @peterjpxie ! Just to note for the record, the context of this is the DIscourse thread here , where the OP originally raised the issue and suggested they go ahead with a PR to fix it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@peterjpxie @Fidget-Spinner
pythongh-103025: fix two ctypes doc issues (python#103026)
537a413
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@peterjpxie @warsaw
pythongh-103025: fix two ctypes doc issues (python#103026)
e7dba47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@peterjpxie @miss-islington @bedevere-bot @CAM-Gerlach @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.