GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103054: Improve `Callable` type subtitution tests by sobolevn · Pull Request #103055 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Mar 27, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Any other test suggestions are welcome! 👍

  • Issue: Improve test cases for type substitution of a list of types after initial ParamSpec substitution #103054

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-103054: Improve Callable type subtitution tests
12a9668
@sobolevn
sobolevn requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners March 27, 2023 08:29
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 27, 2023
Improve test cases for type substitution of a list of types after initial ParamSpec substitution #103054
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 27, 2023
@sobolevn sobolevn added the skip news label Mar 27, 2023
@sobolevn

sobolevn commented Mar 27, 2023

Copy link
Copy Markdown
Member Author

I understand why some people are afraid of typing 🙈
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4
Eclips4 reviewed Mar 28, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood @Eclips4
Fix typo
f94f6c9 
Co-authored-by: Eclips4 <[email protected]>
JelleZijlstra
JelleZijlstra approved these changes Mar 29, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 29, 2023
@JelleZijlstra JelleZijlstra added the needs backport to 3.11 only security fixes label Mar 29, 2023
@JelleZijlstra
JelleZijlstra merged commit 60bdc16 into python:main Mar 29, 2023
@miss-islington

miss-islington commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 29, 2023
@bedevere-bot

bedevere-bot commented Mar 29, 2023

Copy link
Copy Markdown

GH-103105 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 29, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 29, 2023
@sobolevn @AlexWaygood
@Eclips4 @miss-islington
pythongh-103054: typing: Improve Callable type substitution tests (p…
8e06aa8 
…ythonGH-103055)

(cherry picked from commit 60bdc16)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Eclips4 <[email protected]>
miss-islington added a commit that referenced this pull request Mar 29, 2023
@miss-islington @sobolevn
@AlexWaygood @Eclips4
gh-103054: typing: Improve Callable type substitution tests (GH-103055
766038d 
)

(cherry picked from commit 60bdc16)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Eclips4 <[email protected]>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@sobolevn @AlexWaygood
@Eclips4 @warsaw
pythongh-103054: typing: Improve Callable type substitution tests (p…
d067d26 
…ython#103055)

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Eclips4 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sobolevn @miss-islington @bedevere-bot @JelleZijlstra @Eclips4 @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.