GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103097: Add workaround for Windows ARM64 compiler bug by zooba · Pull Request #103098 · python/cpython

Conversation

@zooba

@zooba zooba commented Mar 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Windows ARM64 builds fail index tests #103097

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
zooba added 4 commits March 28, 2023 19:58
@zooba
Add workaround for Windows ARM64 compiler regression
49670ee
@zooba
Ensure VCToolsVersion is not empty
e55554d
@zooba
Only use FileId128 when it is non-zero
7a30dba
@zooba
Revert "Only use FileId128 when it is non-zero"
ecd1575 
This reverts commit 7a30dba.
@zooba zooba added OS-windows skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 28, 2023
@zooba
zooba requested a review from a team as a code owner March 28, 2023 23:13
@bedevere-bot bedevere-bot mentioned this pull request Mar 28, 2023
Windows ARM64 builds fail index tests #103097
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 28, 2023
@zooba

zooba commented Mar 28, 2023

Copy link
Copy Markdown
Member Author

!buildbot .ARM64.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit ecd1575 🤖

The command will test the builders whose names match following regular expression: .*ARM64.*

The builders matched are:

  • ARM64 Windows Non-Debug PR
  • ARM64 Windows PR
  • ARM64 macOS PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 24ba507 into python:main Mar 28, 2023
@miss-islington

miss-islington commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 28, 2023
@zooba
zooba deleted the arm64fix branch March 28, 2023 23:47
@miss-islington

miss-islington commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 24ba507b1dd70cf468a1beadea6ca6336fe1d40f 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned zooba Mar 28, 2023
@miss-islington

miss-islington commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Sorry @zooba, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 24ba507b1dd70cf468a1beadea6ca6336fe1d40f 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba added a commit to zooba/cpython that referenced this pull request Mar 28, 2023
@zooba
pythongh-103097: Add workaround for Windows ARM64 compiler bug (pytho…
81f3189 
…nGH-103098)

See https://developercommunity.visualstudio.com/t/Regression-in-MSVC-1433-1434-ARM64-co/10224361 for details of the issue. It only applies to version 14.34.
@bedevere-bot

bedevere-bot commented Mar 28, 2023

Copy link
Copy Markdown

GH-103101 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 28, 2023
zooba added a commit to zooba/cpython that referenced this pull request Mar 28, 2023
@zooba
pythongh-103097: Add workaround for Windows ARM64 compiler bug (pytho…
3df21d8 
…nGH-103098)

See https://developercommunity.visualstudio.com/t/Regression-in-MSVC-1433-1434-ARM64-co/10224361 for details of the issue. It only applies to version 14.34.
@bedevere-bot

bedevere-bot commented Mar 28, 2023

Copy link
Copy Markdown

GH-103102 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 28, 2023
zooba added a commit that referenced this pull request Mar 29, 2023
@zooba
gh-103097: Add workaround for Windows ARM64 compiler bug (GH-103098)
cbe14c8 
See https://developercommunity.visualstudio.com/t/Regression-in-MSVC-1433-1434-ARM64-co/10224361 for details of the issue. It only applies to version 14.34.
zooba added a commit that referenced this pull request Mar 29, 2023
@zooba
gh-103097: Add workaround for Windows ARM64 compiler bug (GH-103098)
4abf1f1 
See https://developercommunity.visualstudio.com/t/Regression-in-MSVC-1433-1434-ARM64-co/10224361 for details of the issue. It only applies to version 14.34.
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@zooba @warsaw
pythongh-103097: Add workaround for Windows ARM64 compiler bug (pytho…
f01268c 
…nGH-103098)

See https://developercommunity.visualstudio.com/t/Regression-in-MSVC-1433-1434-ARM64-co/10224361 for details of the issue. It only applies to version 14.34.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zooba @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.