GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103099: Link mypy docs from typing.rst by hauntsaninja · Pull Request #103100 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Mar 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Link mypy docs from typing.rst #103099

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hauntsaninja
pythongh-103099: Link mypy docs from typing.rst
e3a08e7
@hauntsaninja
hauntsaninja requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners March 28, 2023 23:24
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Mar 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 28, 2023
Link mypy docs from typing.rst #103099
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 28, 2023
@hauntsaninja hauntsaninja mentioned this pull request Mar 28, 2023
Link to mypy docs python/typing#1380
Merged
@hauntsaninja
extra and
f009a26
JelleZijlstra
JelleZijlstra reviewed Mar 28, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added needs backport to 3.10 topic-typing needs backport to 3.11 only security fixes labels Mar 29, 2023
@hauntsaninja
wording
6b5ac06
AlexWaygood
AlexWaygood reviewed Mar 29, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja @AlexWaygood
Update Doc/library/typing.rst
77ffdef 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood reviewed Mar 29, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Outdated
broadly apply to most Python type checkers, although some parts may still be
specific to mypy.

.. seealso::

@AlexWaygood AlexWaygood Mar 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd prefer it if we had one .. seealso box with multiple links in it, similar to the one we have here, rather than two consecutive .. seealso boxes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hauntsaninja hauntsaninja Mar 29, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the other seealso https://deploy-preview-103100--python-cpython-preview.netlify.app/library/typing.html
I think it's mostly fine, but it's not as nice as the seealso you link because it doesn't have bold headings. I don't really have good heading names in mind, so I'm happy to merge as is.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hauntsaninja
single seealso
6ca2d94
@hauntsaninja hauntsaninja added DO-NOT-MERGE and removed DO-NOT-MERGE labels Mar 29, 2023
@hauntsaninja
link to cheat sheet directly
11da570
@hauntsaninja

hauntsaninja commented Mar 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I made one more change: linking to mypy's type hinting cheat sheet.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn
sobolevn approved these changes Mar 29, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is very much needed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra
JelleZijlstra approved these changes Mar 29, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 29, 2023
@hauntsaninja
hauntsaninja merged commit fda95aa into python:main Mar 30, 2023
@miss-islington

miss-islington commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 30, 2023
@hauntsaninja
hauntsaninja deleted the gh-103099 branch March 30, 2023 08:32
@bedevere-bot

bedevere-bot commented Mar 30, 2023

Copy link
Copy Markdown

GH-103126 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 30, 2023
@bedevere-bot

bedevere-bot commented Mar 30, 2023

Copy link
Copy Markdown

GH-103127 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 30, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2023
@hauntsaninja @miss-islington
pythongh-103099: Link mypy docs from typing.rst (pythonGH-103100)
329f80c 
(cherry picked from commit fda95aa)

Co-authored-by: Shantanu <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2023
@hauntsaninja @miss-islington
pythongh-103099: Link mypy docs from typing.rst (pythonGH-103100)
c4bcff8 
(cherry picked from commit fda95aa)

Co-authored-by: Shantanu <[email protected]>
miss-islington added a commit that referenced this pull request Mar 30, 2023
@miss-islington @hauntsaninja
gh-103099: Link mypy docs from typing.rst (GH-103100)
1b40618 
(cherry picked from commit fda95aa)

Co-authored-by: Shantanu <[email protected]>
miss-islington added a commit that referenced this pull request Mar 30, 2023
@miss-islington @hauntsaninja
gh-103099: Link mypy docs from typing.rst (GH-103100)
ba755a2 
(cherry picked from commit fda95aa)

Co-authored-by: Shantanu <[email protected]>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@hauntsaninja @warsaw
pythongh-103099: Link mypy docs from typing.rst (python#103100)
b188cc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@sobolevn sobolevn sobolevn approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hauntsaninja @miss-islington @bedevere-bot @JelleZijlstra @sobolevn @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.