GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-84783: Mention Author for GH-101264 (make slices hashable) by furkanonder · Pull Request #103146 · python/cpython

Conversation

@furkanonder

@furkanonder furkanonder commented Mar 31, 2023 •
edited by terryjreedy
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Will Bradshaw contributed original patch on bpo-40603.

  • Issue: slice not hashable #84783

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@furkanonder
Mention Author for pythonGH-101264 (Make the slice object hashable)
b1edad1
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Mar 31, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 31, 2023
Mention Author in What's New for GH-101264 (Make the slice object hashable) #103145
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 31, 2023
@terryjreedy terryjreedy self-assigned this Mar 31, 2023
terryjreedy
terryjreedy approved these changes Mar 31, 2023
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think original author should come first. Will merge after CI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/3.12.0a6.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 31, 2023
terryjreedy added 2 commits March 31, 2023 09:43
@terryjreedy
Update Doc/whatsnew/3.12.rst
ee1821a
@terryjreedy
Update Misc/NEWS.d/3.12.0a6.rst
5f4c26b
@terryjreedy terryjreedy changed the title GH-103145: Mention Author for GH-101264 (Make the slice object hashable) GH-84783: Mention Author for GH-101264 (make slices hashable) Mar 31, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 31, 2023
slice not hashable #84783
Closed
@terryjreedy
terryjreedy merged commit 048d624 into python:main Mar 31, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 31, 2023
@arhadthedev arhadthedev removed a link to an issue Apr 7, 2023
MANAGER CREDENTIALS #103345
Closed
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@furkanonder @terryjreedy @warsaw
pythonGH-84783: Mention Author for pythonGH-101264 (make slices hasha…
7ef1570 
…ble) (python#103146)

Will Bradshaw contributed original patch on bpo-40603.
---------

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@furkanonder @terryjreedy @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.