GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101659: Clean Up the General Import Tests for Subinterpreters by ericsnowcurrently · Pull Request #103151 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Mar 31, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This involves 3 changes: some general cleanup, checks to match the kind of module, and switch from testing against sys to _imp.

This is a precursor to gh-103150, though the changes are meant to stand on their own.

  • Issue: Isolate the Default Object Allocator between Interpreters #101659

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ericsnowcurrently added 3 commits March 31, 2023 11:28
@ericsnowcurrently
Don't test against sys (for now).
88c099b
@ericsnowcurrently
Clean up SubinterpImportTests.
e7ee839
@ericsnowcurrently
Ensure we are testing against the right type of extension.
9c8d480
@ericsnowcurrently ericsnowcurrently added the skip news label Mar 31, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 31, 2023
Isolate the Default Object Allocator between Interpreters #101659
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 31, 2023
@ericsnowcurrently
ericsnowcurrently merged commit dfc4c95 into python:main Mar 31, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 31, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-subinterp-import-tests branch March 31, 2023 18:18
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@ericsnowcurrently @warsaw
pythongh-101659: Clean Up the General Import Tests for Subinterpreters (
8a65290
pythongh-103151)

This involves 3 changes: some general cleanup, checks to match the kind of module, and switch from testing against sys to _imp.

This is a precursor to pythongh-103150, though the changes are meant to stand on their own.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.