GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103176: sys._current_exceptions() returns mapping to exception instances instead of exc_info tuples by iritkatriel · Pull Request #103177 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Apr 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #103176.

I think this is internal and esoteric enough to not require a deprecation cycle.

  • Issue: sys._current_exceptions() should return exceptions rather than exc_info tuples #103176

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-103176: sys._current_exceptions() returns mapping to excepti…
a0c87eb 
…on instances instead of exc_info tuples
@bedevere-bot bedevere-bot added the awaiting core review label Apr 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 1, 2023
sys._current_exceptions() should return exceptions rather than exc_info tuples #103176
Closed
@iritkatriel
iritkatriel marked this pull request as draft April 1, 2023 22:11
@iritkatriel
iritkatriel marked this pull request as ready for review April 6, 2023 15:03
@Yhg1s

Yhg1s commented Apr 10, 2023

Copy link
Copy Markdown
Member

FYI, I discussed this with the SC, and considering it's a private API that's relatively new and has very few uses, changing the behaviour is fine. (I also have to say I'm very amused that the documentation didn't even clarify that the value was the 3-tuple, before 😂)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s
Yhg1s approved these changes Apr 10, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 10, 2023
@iritkatriel
iritkatriel merged commit 78b763f into python:main Apr 11, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 11, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@iritkatriel @warsaw
pythongh-103176: sys._current_exceptions() returns mapping to excepti…
305294c 
…on instances instead of exc_info tuples (python#103177)
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@iritkatriel @aisk
pythongh-103176: sys._current_exceptions() returns mapping to excepti…
993d297 
…on instances instead of exc_info tuples (python#103177)
@iritkatriel
iritkatriel deleted the _current_exceptions branch July 25, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sys._current_exceptions() should return exceptions rather than exc_info tuples

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.