GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93910: [Enum] remove member.member deprecation by ethanfurman · Pull Request #103236 · python/cpython

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Apr 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

One edge case not passing, but otherwise this will give us an idea of any performance boost.

  • Issue: Change in semantics and much worse performance for enum members. #93910
  • Issue: [Enum] Deprecate member.member access with removal in 3.14 #95077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ethanfurman
test code for enum attribute speed-up
992c2c8
@ethanfurman ethanfurman added performance Performance or resource usage DO-NOT-MERGE stdlib Standard Library Python modules in the Lib/ directory 3.12 only security fixes labels Apr 4, 2023
@ethanfurman ethanfurman self-assigned this Apr 4, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Apr 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 4, 2023
Change in semantics and much worse performance for enum members. #93910
Closed
@ethanfurman
remove member.member deprecation
c94b336 
i.e. Color.RED.BLUE is now officially supported.
@ethanfurman ethanfurman removed the DO-NOT-MERGE label Apr 4, 2023
@ethanfurman

ethanfurman commented Apr 4, 2023

Copy link
Copy Markdown
Member Author

Updated docs and tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ethanfurman
Merge branch 'main' into enum-fast
0be30a4
@ethanfurman ethanfurman mentioned this pull request Apr 5, 2023
[Enum] officially support member.member access and remove deprecation python/steering-council#182
Closed
@ethanfurman ethanfurman changed the title gh-93910: [Enum] test code for enum attribute speed-up gh-93910: [Enum] remove member.member deprecation Apr 5, 2023
@ethanfurman
remove commented-out code
281d835
@ethanfurman
ethanfurman merged commit 4ec8dd1 into python:main Apr 6, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 6, 2023
@ethanfurman ethanfurman added 3.11 only security fixes needs backport to 3.11 only security fixes labels Apr 6, 2023
@miss-islington

miss-islington commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Sorry, @ethanfurman, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4ec8dd10bd4682793559c4eccbcf6ae00688c4c3 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 6, 2023

Copy link
Copy Markdown

GH-103299 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 6, 2023
ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Apr 6, 2023
@ethanfurman
[3.11] pythongh-93910: [Enum] remove member.member deprecation (pyth…
e573165 
…onGH-103236)

i.e. Color.RED.BLUE is now officially supported..
                    (cherry picked from commit 4ec8dd1)

                    Co-authored-by: Ethan Furman <[email protected]>
@ethanfurman
ethanfurman deleted the enum-fast branch April 6, 2023 03:30
ethanfurman added a commit that referenced this pull request Apr 6, 2023
@ethanfurman
[3.11] gh-93910: [Enum] remove member.member deprecation (GH-103236) (G…
58e330a 
…H-103299)

i.e. Color.RED.BLUE is now officially supported..
(cherry picked from commit 4ec8dd1)

Co-authored-by: Ethan Furman <[email protected]>
gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this pull request Apr 8, 2023
@ethanfurman @gaogaotiantian
pythongh-93910: [Enum] remove member.member deprecation (pythonGH-103236
b536c34 
)

i.e. Color.RED.BLUE is now officially supported.
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@ethanfurman @warsaw
pythongh-93910: [Enum] remove member.member deprecation (pythonGH-103236
ac56605 
)

i.e. Color.RED.BLUE is now officially supported.
@jacobtylerwalls jacobtylerwalls mentioned this pull request Jul 15, 2023
[3.12] EnumMeta.__getattr__ removed without deprecation #106762
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ethanfurman ethanfurman

Labels

3.11 only security fixes 3.12 only security fixes performance Performance or resource usage stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ethanfurman @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.