GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-103092: Isolate winreg by aisk · Pull Request #103250 · python/cpython

Conversation

aisk commented Apr 4, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Isolate Stdlib Extension Modules #103092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-103092: isolate winreg

c26eadc

aisk requested a review from a team as a code owner

April 4, 2023 16:08

bedevere-bot added the awaiting review label

Apr 4, 2023

aisk marked this pull request as draft

April 4, 2023 16:09

bedevere-bot mentioned this pull request

Apr 4, 2023

Isolate Stdlib Extension Modules #103092

Closed

24 of 25 tasks

arhadthedev reviewed

Apr 5, 2023

View reviewed changes

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

aisk and others added 4 commits

April 6, 2023 15:25


          Update PC/winreg.c

cb77580

Co-authored-by: Oleg Iarygin <[email protected]>


          finish the isolate

1f0ecc0


          add tests for winreg

d48fc88


          add news

aisk marked this pull request as ready for review

April 7, 2023 16:50

Eclips4 commented Apr 8, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Hm.. CI/CD says there is a certain amount of refleaks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aisk commented Apr 8, 2023

Copy link

Copy Markdown

Member Author

Yes, working on it

Eclips4 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland self-requested a review

April 8, 2023 19:48

erlend-aasland changed the title ~~gh-103092: isolate winreg~~ gh-103092: Isolate winreg

Apr 8, 2023

erlend-aasland reviewed

Apr 8, 2023

View reviewed changes

Comment thread

Lib/test/test_winreg.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2023-04-08-00-48-40.gh-issue-103092.5EFts0.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

aisk and others added 10 commits

April 9, 2023 13:59


          Update Lib/test/test_winreg.py

71547ef

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update Misc/NEWS.d/next/Library/2023-04-08-00-48-40.gh-issue-103092.5…

1b5b873

…EFts0.rst

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

a4eb9c5

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

179416a

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

73f3ffe

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

dff3839

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

Co-authored-by: Erlend E. Aasland <[email protected]>


          fix gc track on PyHKEY

3f1cd90


          using Py_Type to get class instead of using defining_class and

f3da318

using PyModule_GetState instead of _PyModule_GetState


          fix the memory leak

a2017d1

aisk requested a review from erlend-aasland

April 9, 2023 12:06

erlend-aasland reviewed

Apr 9, 2023

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we're soon ready for landing (and of course a thumbs up from Steve or someone else from the Windows team).

I left some more nit picks :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_winreg.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Eclips4 reviewed

Apr 9, 2023

View reviewed changes

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update PC/winreg.c

80af80c

Co-authored-by: Erlend E. Aasland <[email protected]>

aisk and others added 6 commits

April 10, 2023 17:37


          Update PC/winreg.c

488cae8

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

bbd1d6d

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

45fedf6

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

964e1dd

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

16de5c6

Co-authored-by: Erlend E. Aasland <[email protected]>


          Update PC/winreg.c

Co-authored-by: Kirill <[email protected]>

arhadthedev reviewed

Apr 10, 2023

View reviewed changes

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

aisk added 3 commits

April 10, 2023 21:58


          nit fixes

ae54a8e


          fix syntax error

42bcb44


          passing state instead of module in c level module functions

1998c06

erlend-aasland reviewed

Apr 10, 2023

View reviewed changes

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

aisk and others added 2 commits

April 11, 2023 23:14


          Update PC/winreg.c

682c419

Co-authored-by: Erlend E. Aasland <[email protected]>


          check result of gc new

8b1aaa4

aisk mentioned this pull request

Apr 11, 2023

gh-83004: Harden winreg init #103386

Merged


          Merge remote-tracking branch 'upstream/main' into isolate-winreg

25a7f73

erlend-aasland reviewed

Apr 12, 2023

View reviewed changes

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

aisk and others added 2 commits

April 12, 2023 20:35


          Update PC/winreg.c

3ecc718

Co-authored-by: Erlend E. Aasland <[email protected]>


          remove unused PyHKEY_NumberMethods

e279c84

aisk requested a review from erlend-aasland

April 12, 2023 12:41

erlend-aasland approved these changes

Apr 13, 2023

View reviewed changes

Comment thread

PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting merge and removed awaiting review labels

Apr 13, 2023


          Update PC/winreg.c

d7f97fc

erlend-aasland requested a review from zooba

April 13, 2023 12:41

erlend-aasland commented Apr 13, 2023

Copy link

Copy Markdown

Contributor

Thanks, @aisk!

Let's wait for Steve's thumbs up before we land this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aisk commented Apr 13, 2023

Copy link

Copy Markdown

Member Author

Great thanks for helping and review this! @erlend-aasland

erlend-aasland reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zooba commented Apr 17, 2023

Copy link

Copy Markdown

Member

Seems okay to me, though I'm not really up on these conversions. If all the tests (esp. refleak tests) are still passing, it's presumably fine.

erlend-aasland and aisk reacted with heart emoji

All reactions

❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland merged commit d83faf7 into python:main

Apr 17, 2023

bedevere-bot removed the awaiting merge label

Apr 17, 2023

aisk deleted the isolate-winreg branch

April 18, 2023 04:22

Reviewers

arhadthedev

arhadthedev left review comments

Eclips4

Eclips4 left review comments

erlend-aasland

erlend-aasland approved these changes

zooba

Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

aisk commented Apr 4, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Eclips4 commented Apr 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aisk commented Apr 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Apr 13, 2023

Uh oh!

aisk commented Apr 13, 2023

Uh oh!

zooba commented Apr 17, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aisk commented Apr 4, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Eclips4 commented Apr 8, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.