GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83004: Harden winreg init by erlend-aasland · Pull Request #103386 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improve stdlib module initialization error handling. #83004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot mentioned this pull request Apr 8, 2023
Improve stdlib module initialization error handling. #83004
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 8, 2023
@erlend-aasland erlend-aasland added the skip news label Apr 8, 2023
@erlend-aasland
pythongh-83004: Harden winreg init
e664a52
@erlend-aasland
erlend-aasland force-pushed the cleanup-winreg branch from 2c298f2 to e664a52 Compare April 8, 2023 22:34
@erlend-aasland
erlend-aasland marked this pull request as ready for review April 8, 2023 23:02
@erlend-aasland
erlend-aasland requested a review from a team as a code owner April 8, 2023 23:02
@erlend-aasland
erlend-aasland requested a review from zooba April 8, 2023 23:02
@erlend-aasland

erlend-aasland commented Apr 10, 2023

Copy link
Copy Markdown
Contributor Author

@zooba, I'm landing this later tonight.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 5ed2f19 into python:main Apr 10, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 10, 2023
@erlend-aasland
erlend-aasland deleted the cleanup-winreg branch April 10, 2023 20:58
aisk
aisk reviewed Apr 11, 2023
View reviewed changes
Comment thread PC/winreg.c
ADD_INT(REG_FULL_RESOURCE_DESCRIPTOR);
ADD_INT(REG_RESOURCE_REQUIREMENTS_LIST);

#undef ADD_INT

@aisk aisk Apr 11, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we undef the ADD_KEY here also?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Apr 11, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ideally, but not worth a separate PR, IMO.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@aisk aisk Apr 11, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to merge this to #103250 , I'll add it is this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@erlend-aasland @warsaw
pythongh-83004: Harden winreg init (python#103386)
e5d9087
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@erlend-aasland @aisk
pythongh-83004: Harden winreg init (python#103386)
e3f10e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments
@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @aisk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.