GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83004: Harden _socket init by erlend-aasland · Pull Request #103261 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 5, 2023 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improve stdlib module initialization error handling. #83004

Automerge-Triggered-By: GH:erlend-aasland

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-83004: Harden _socket init
8f9bea1
@bedevere-bot bedevere-bot added the awaiting core review label Apr 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 5, 2023
Improve stdlib module initialization error handling. #83004
Closed
@erlend-aasland
#undef ADD_STR_CONST
0722e40
@erlend-aasland

erlend-aasland commented Apr 5, 2023

Copy link
Copy Markdown
Contributor Author

See also gh-99044 for a partial hardening.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland requested a review from hauntsaninja April 5, 2023 00:20
@erlend-aasland erlend-aasland added skip news 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Apr 5, 2023
@bedevere-bot

bedevere-bot commented Apr 5, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 0722e40 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 5, 2023
@erlend-aasland erlend-aasland mentioned this pull request Apr 5, 2023
gh-103092: Isolate socket #103094
Merged
hauntsaninja
hauntsaninja approved these changes Apr 7, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Modules/socketmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 7, 2023
erlend-aasland added 2 commits April 8, 2023 01:11
@erlend-aasland
Pull in main
6081004
@erlend-aasland
Be explicit: make exc base a param of the ADD_EXC macro
3f5e7b2
@erlend-aasland erlend-aasland added the 🤖 automerge label Apr 7, 2023
@miss-islington

miss-islington commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 91794e5 into python:main Apr 7, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 7, 2023
@erlend-aasland
erlend-aasland deleted the cleanup-socket-init branch April 8, 2023 08:13
@erlend-aasland erlend-aasland mentioned this pull request Apr 8, 2023
gh-83004: Clean up refleaks in ssl, socket initialisation #99044
Closed
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@erlend-aasland @warsaw
pythongh-83004: Harden _socket init (pythonGH-103261)
e7d348e 
Automerge-Triggered-By: GH:erlend-aasland
@mattip mattip mentioned this pull request Sep 27, 2026
typo in rsocket.py: instead of ALG_SET_PUB_KEY it should be ALG_SET_PUBKEY pypy/pypy#5594
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @bedevere-bot @miss-islington @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.