GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103224: Resolve paths properly in `test_sysconfig` by artemmukhin · Pull Request #103292 · python/cpython

Conversation

@artemmukhin

@artemmukhin artemmukhin commented Apr 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Now running tests through a Python symlink no longer causes test_nt_venv_scheme and test_posix_venv_scheme to fail.

@hroncok Thank you for helping!

  • Issue: Virtual environment breaks test_sysconfig and test_venv tests on macOS #103224

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@artemmukhin @hroncok
pythonGH-103224: Resolve paths properly in test_sysconfig
51f0236 
To pass tests when executed through a Python symlink.

Co-authored-by: Miro Hrončok <[email protected]>
@artemmukhin
artemmukhin requested a review from FFY00 as a code owner April 5, 2023 21:34
@bedevere-bot bedevere-bot added the awaiting review label Apr 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 5, 2023
Virtual environment breaks test_sysconfig and test_venv tests on macOS #103224
Open
2 tasks
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 5, 2023
@serhiy-storchaka
Merge branch 'main' into fix-test_sysconfig-python-symlink
7260188
serhiy-storchaka
serhiy-storchaka approved these changes Feb 6, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks safe.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 6, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) February 6, 2024 17:25
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 6, 2024
@serhiy-storchaka serhiy-storchaka changed the title GH-103224: Resolve paths properly in test_sysconfig gh-103224: Resolve paths properly in test_sysconfig Feb 6, 2024
@serhiy-storchaka serhiy-storchaka added the skip news label Feb 6, 2024
@serhiy-storchaka
serhiy-storchaka merged commit 71239d5 into python:main Feb 6, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 6, 2024

Copy link
Copy Markdown

Thanks @artemmukhin for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2024
@artemmukhin @hroncok @miss-islington
pythongh-103224: Resolve paths properly in test_sysconfig (pythonGH-1…
bce6ca7 
…03292)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <[email protected]>
Co-authored-by: Miro Hrončok <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 6, 2024

Copy link
Copy Markdown

GH-115100 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2024
@artemmukhin @hroncok @miss-islington
pythongh-103224: Resolve paths properly in test_sysconfig (pythonGH-1…
763af10 
…03292)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <[email protected]>
Co-authored-by: Miro Hrončok <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 6, 2024

Copy link
Copy Markdown

GH-115101 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Feb 6, 2024
serhiy-storchaka pushed a commit that referenced this pull request Feb 7, 2024
@miss-islington @artemmukhin @hroncok
[3.12] gh-103224: Resolve paths properly in test_sysconfig (GH-103292) (
060c3ed 
GH-115100)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <[email protected]>
Co-authored-by: Miro Hrončok <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Feb 7, 2024
@miss-islington @artemmukhin @hroncok
[3.11] gh-103224: Resolve paths properly in test_sysconfig (GH-103292) (
3aa4418 
GH-115101)

To pass tests when executed through a Python symlink.

(cherry picked from commit 71239d5)

Co-authored-by: Artem Mukhin <[email protected]>
Co-authored-by: Miro Hrončok <[email protected]>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@artemmukhin @hroncok @fsc-eriker
pythongh-103224: Resolve paths properly in test_sysconfig (pythonGH-1…
d0c42eb 
…03292)

To pass tests when executed through a Python symlink.

Co-authored-by: Miro Hrončok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@artemmukhin @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.