GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — gh-103193: Use LBYL idioms rather than EAFP in `inspect.getattr_static` by AlexWaygood · Pull Request #103318 · python/cpython Conversation
|
|
Skipping news, since the news entry in #103195 should suffice, I think. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
It's less idiomatic code, but I think it's worth it for the very significant performance improvement on runtime protocol isinstance checking with many attributes.
I assume you've checked the performance of using .get(...) and it's worse?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Hmm I haven't, actually -- not sure how you'd use |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh I think I see what you mean. Trying it out now. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yeah, I tried out doing this instead (diff is relative to my current patch, not to diff --git a/Lib/inspect.py b/Lib/inspect.py index a317f0ca74..7fcaa13750 100644 --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1787,8 +1787,10 @@ def _check_instance(obj, attr): def _check_class(klass, attr): for entry in _static_getmro(klass): - if _shadowed_dict(type(entry)) is _sentinel and attr in entry.__dict__: - return entry.__dict__[attr] + if _shadowed_dict(type(entry)) is _sentinel: + ret = entry.__dict__.get(attr, _sentinel) + if ret is not _sentinel: + return ret return _sentinel def _is_type(obj): @@ -1800,13 +1802,13 @@ def _is_type(obj): def _shadowed_dict(klass): for entry in _static_getmro(klass): - dunder_dict = _get_dunder_dict_of_class(entry) - if '__dict__' in dunder_dict: - class_dict = dunder_dict['__dict__'] - if not (type(class_dict) is types.GetSetDescriptorType and - class_dict.__name__ == "__dict__" and - class_dict.__objclass__ is entry): - return class_dict + class_dict = _get_dunder_dict_of_class(entry).get('__dict__', _sentinel) + if class_dict is not _sentinel and not ( + type(class_dict) is types.GetSetDescriptorType + and class_dict.__name__ == "__dict__" + and class_dict.__objclass__ is entry + ): + return class_dict return _sentinel def getattr_static(obj, attr, default=_sentinel): @@ -1845,11 +1847,10 @@ def getattr_static(obj, attr, default=_sentinel): if obj is klass: # for types we check the metaclass too for entry in _static_getmro(type(klass)): - if ( - _shadowed_dict(type(entry)) is _sentinel - and attr in entry.__dict__ - ): - return entry.__dict__[attr] + if _shadowed_dict(type(entry)) is _sentinel: + ret = entry.__dict__.get(attr, _sentinel) + if ret is not _sentinel: + return ret @carljm is that the kind of thing you were talking about? :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks both! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.