GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-102213: Optimize the performance of `__getattr__` (GH-102248)" by sobolevn · Pull Request #103332 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Apr 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This commit caused at least two regressions:

  1. Maximum recursion depth exceeded in __getattr__(). #103272
  2. 3.12.0a7 changes behavior of PropertyMock #103329

CC @wangxiang-hz @Fidget-Spinner @sunmy2019

@sunmy2019 can you please send your test case as the next PR?
I want to keep this one a pure revert, with no extra changes :)

  • Issue: Improve the Efficiency of Python3.11.1 __getattr__ #102213

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
Revert "pythongh-102213: Optimize the performance of __getattr__ (p…
96946fd 
…ythonGH-102248)"

This reverts commit aa0a73d.
@sobolevn
sobolevn requested a review from markshannon as a code owner April 7, 2023 05:47
@bedevere-bot bedevere-bot mentioned this pull request Apr 7, 2023
Improve the Efficiency of Python3.11.1 __getattr__ #102213
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 7, 2023
@sobolevn sobolevn added the skip news label Apr 7, 2023
@sunmy2019

sunmy2019 commented Apr 7, 2023

Copy link
Copy Markdown
Member

Sure, but do you know which file should I add this to?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

I think that this one is the best place: https://github.com/python/cpython/blob/main/Lib/test/test_descr.py
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunmy2019 sunmy2019 mentioned this pull request Apr 7, 2023
gh-103272: add regression test for getattr that raises #103336
Merged
Fidget-Spinner
Fidget-Spinner approved these changes Apr 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 7, 2023
@Fidget-Spinner
Fidget-Spinner merged commit 059bb04 into python:main Apr 7, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 7, 2023
@sunmy2019 sunmy2019 mentioned this pull request Apr 7, 2023
3.12.0a7 changes behavior of PropertyMock #103329
Closed
This was referenced Apr 8, 2023
gh-103329: Add regression test for PropertyMock with side effect #103358
Merged
CI Tests Failure with Release of Python 3.12.0-alpha.7 beeware/briefcase#1165
Closed
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@sobolevn @warsaw
pythongh-102213: Revert "pythongh-102213: Optimize the performance of…
ef37048 
… `__getattr__` (pythonGH-102248)" (pythonGH-103332)

This reverts commit aa0a73d.
@AlexWaygood AlexWaygood mentioned this pull request Apr 14, 2023
[3.12] Behavior change: __getattr__ gets called after property raises NotImplementedError #103551
Closed
@sunmy2019 sunmy2019 mentioned this pull request Apr 20, 2023
Unexpected SystemError in Python3.12.0a7: <method 'startswith' of 'str' objects> returned a result with an exception set #103632
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @sunmy2019 @Fidget-Spinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.