GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer by iritkatriel · Pull Request #103339 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Apr 7, 2023 •
edited by terryjreedy
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Pass the exception as an argument instead of as a sys attribute.

  • Issue: IDLE - Remove use of deprecated sys.last_xyzs in stackviewer #102832

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-102832: [idle] reduce use of deprecated sys.last_xyzs
1178a32
@iritkatriel
iritkatriel requested a review from terryjreedy as a code owner April 7, 2023 10:12
@bedevere-bot bedevere-bot mentioned this pull request Apr 7, 2023
IDLE - Remove use of deprecated sys.last_xyzs in stackviewer #102832
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 7, 2023
@iritkatriel
remove last_xyzs from test as well
a16e192
@iritkatriel

iritkatriel commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

I see - the tests are skipped on Mac so I didn’t see them fail. I’ll try later on windows and fix this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
tolerate exc == None
b7ef0e1
@iritkatriel iritkatriel added skip news stdlib Standard Library Python modules in the Lib/ directory labels Apr 7, 2023
terryjreedy
terryjreedy requested changes Apr 7, 2023
View reviewed changes

@terryjreedy terryjreedy left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order of PRs: (edited)

  1. Set sys.last_exc in run print_exception. #103314 (Done)
  2. Patch pyshell open_stack_viewer (comment on StackBrowser/stackbrowser)
  3. Apply this with changes and additional changes to open_stack_viewer and run-stackviewer and maybe new unittests.

Now working on 2 and 3.

The comments make a bit more sense when read in order on the diff page.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/idlelib/stackviewer.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/idlelib/stackviewer.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/idlelib/stackviewer.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/idlelib/stackviewer.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/idlelib/stackviewer.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/idlelib/stackviewer.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/idlelib/idle_test/test_stackviewer.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 7, 2023
@bedevere-bot

bedevere-bot commented Apr 7, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Apr 7, 2023
@terryjreedy terryjreedy changed the title gh-102832: [idle] reduce use of deprecated sys.last_xyzs gh-102832: IDLE - reduce use of deprecated sys.last_xyzs Apr 7, 2023
@terryjreedy terryjreedy self-assigned this Apr 7, 2023
@terryjreedy terryjreedy changed the title gh-102832: IDLE - reduce use of deprecated sys.last_xyzs gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer Apr 19, 2023
@terryjreedy

terryjreedy commented Apr 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I am reversing 2. patch open_stack_viewer and 3. everything else by including changing open_stack_viewer to pass sys.last_value, which is valid in 3.11 and 3.12.

After merging this, I will patch main and 3.12 only to pass last_exc instead of last_value, thus removing, I believe, the last use of a deprecated value.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

Sorry, this seems to have dropped off my radar somehow. I'll update it now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

Actually, are you working on this? (You seem to indicate so in #103339 (review)).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Jun 7, 2023

Copy link
Copy Markdown
Member

I have a partly done branch. Will make this a priority tomorrow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy marked this pull request as draft June 8, 2023 01:21
@bedevere-bot bedevere-bot removed the awaiting changes label Jun 8, 2023
terryjreedy added 4 commits June 7, 2023 21:24
@terryjreedy
Merge remote-tracking branch 'upstream/main' into pr_103339
632533e
@terryjreedy
Fix StackBrowser def and test calls.
7a6839b
@terryjreedy
Fix pyshell -n mode Stackbrowser call.
e84e58f 
Tested by running in -n mode.
@terryjreedy
Fix StackTreeItem def and calls.
144d3fd
@terryjreedy terryjreedy added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 8, 2023
@terryjreedy
terryjreedy marked this pull request as ready for review June 8, 2023 03:48
@bedevere-bot bedevere-bot added the awaiting core review label Jun 8, 2023
terryjreedy
terryjreedy approved these changes Jun 8, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 8, 2023
@terryjreedy

terryjreedy commented Jun 8, 2023

Copy link
Copy Markdown
Member

Assuming CI passes, I believe ready now. Will recheck tomorrow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
indent fix
bbd7e0c
iritkatriel
iritkatriel commented Jun 8, 2023
View reviewed changes
Comment thread Lib/idlelib/pyshell.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 3ee921d into python:main Jun 8, 2023
@miss-islington

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
@iritkatriel @miss-islington
pythongh-102832: IDLE - remove use of deprecated sys.last_xyzs for st…
894fdf3 
…ackviewer (pythonGH-103339)

(cherry picked from commit 3ee921d)

Co-authored-by: Irit Katriel <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
@iritkatriel @miss-islington
pythongh-102832: IDLE - remove use of deprecated sys.last_xyzs for st…
89d3962 
…ackviewer (pythonGH-103339)

(cherry picked from commit 3ee921d)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 8, 2023

Copy link
Copy Markdown

GH-105526 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 8, 2023
@bedevere-bot

bedevere-bot commented Jun 8, 2023

Copy link
Copy Markdown

GH-105527 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 8, 2023
terryjreedy pushed a commit that referenced this pull request Jun 8, 2023
@miss-islington @iritkatriel
[3.11] gh-102832: IDLE - remove use of deprecated sys.last_xyzs for s…
c2df09f 
…tackviewer (GH-103339) (#105527)

gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer (GH-103339)
(cherry picked from commit 3ee921d)

Co-authored-by: Irit Katriel <[email protected]>
terryjreedy pushed a commit that referenced this pull request Jun 8, 2023
@miss-islington @iritkatriel
[3.12] gh-102832: IDLE - remove use of deprecated sys.last_xyzs for s…
f565fed 
…tackviewer (GH-103339) (#105526)

gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer (GH-103339)
(cherry picked from commit 3ee921d)

Co-authored-by: Irit Katriel <[email protected]>
@iritkatriel
iritkatriel deleted the stackbrowser branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

skip news stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @bedevere-bot @terryjreedy @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.