GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83004: Harden winsound init by erlend-aasland · Pull Request #103385 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improve stdlib module initialization error handling. #83004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-83004: Harden winsound init
ecef2d9
@bedevere-bot bedevere-bot mentioned this pull request Apr 8, 2023
Improve stdlib module initialization error handling. #83004
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 8, 2023
@erlend-aasland erlend-aasland added the skip news label Apr 8, 2023
@erlend-aasland
erlend-aasland marked this pull request as ready for review April 8, 2023 21:00
@erlend-aasland
erlend-aasland requested a review from a team as a code owner April 8, 2023 21:00
@erlend-aasland
erlend-aasland requested review from hauntsaninja and zooba April 8, 2023 21:00
@erlend-aasland erlend-aasland mentioned this pull request Apr 8, 2023
gh-103092: Isolate winsound #103249
Merged
hauntsaninja
hauntsaninja reviewed Apr 8, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Should we decref module in the error case?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@erlend-aasland
Don't leak module object on error
aa5901e
erlend-aasland
erlend-aasland commented Apr 8, 2023
View reviewed changes
Comment thread PC/winsound.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 @erlend-aasland
Update PC/winsound.c
df65947 
Co-authored-by: Erlend E. Aasland <[email protected]>
kumaraditya303
kumaraditya303 approved these changes Apr 9, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 9, 2023
@erlend-aasland

erlend-aasland commented Apr 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Kumar & Shantanu!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 6d97e52 into python:main Apr 9, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 9, 2023
@erlend-aasland
erlend-aasland deleted the cleanup-winsound branch April 9, 2023 20:00
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@erlend-aasland @warsaw
pythongh-83004: Harden winsound init (python#103385)
84ac912
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@erlend-aasland @aisk
pythongh-83004: Harden winsound init (python#103385)
4ea911f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @hauntsaninja @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.