GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-77757: replace exception wrapping by PEP-678 notes in typeobject's __set_name__ by iritkatriel · Pull Request #103402 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Apr 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #77757.

  • Issue: Make exception wrapping less intrusive for __set_name__ calls #77757

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-77757: replace exception wrapping by PEP-678 notes in typeob…
d7156e6 
…ject's __set_name__
@iritkatriel
iritkatriel requested review from markshannon and rhettinger as code owners April 9, 2023 21:16
@bedevere-bot bedevere-bot mentioned this pull request Apr 9, 2023
Make exception wrapping less intrusive for __set_name__ calls #77757
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 9, 2023
@iritkatriel
add news
beaf88a
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 9, 2023
@bedevere-bot

bedevere-bot commented Apr 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit beaf88a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 9, 2023
carljm
carljm approved these changes Apr 10, 2023
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer, thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 10, 2023
@iritkatriel

iritkatriel commented Apr 10, 2023

Copy link
Copy Markdown
Member Author

Thanks, I just want to refactor some common code into a new function.
carljm reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added 2 commits April 10, 2023 18:43
@iritkatriel
refactor common code into a new _PyErr_FormatNote function
0068e9c
@iritkatriel
put back 'goto error'
31d4202
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 10, 2023
@bedevere-bot

bedevere-bot commented Apr 10, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 31d4202 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 10, 2023
@iritkatriel
Merge branch 'main' into note
4d9c542
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 10, 2023
@bedevere-bot

bedevere-bot commented Apr 10, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 4d9c542 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 10, 2023
@rhettinger
rhettinger removed their request for review April 11, 2023 03:00
@iritkatriel
Merge branch 'main' into note
dc9d914
@iritkatriel
iritkatriel merged commit 55c99d9 into python:main Apr 11, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 11, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@iritkatriel @warsaw
pythongh-77757: replace exception wrapping by PEP-678 notes in typeob…
f28d73e 
…ject's __set_name__ (python#103402)
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@iritkatriel @aisk
pythongh-77757: replace exception wrapping by PEP-678 notes in typeob…
bdeb708 
…ject's __set_name__ (python#103402)
scoder added a commit to cython/cython that referenced this pull request Jun 27, 2023
@scoder
Fix test in Py3.12 after behavioural changes in CPython.
f6b0ae5 
See python/cpython#77757
See python/cpython#103402
@iritkatriel
iritkatriel deleted the note branch July 25, 2023 18:05
@fantix fantix mentioned this pull request Aug 15, 2024
Upgrade libuv to v1.48.0 MagicStack/uvloop#600
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make exception wrapping less intrusive for __set_name__ calls

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @bedevere-bot @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.