GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-103082: Code cleanup from review. by markshannon · Pull Request #103474 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Apr 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Implement and document PEP 669. #103082

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Code cleanup
fb56027
@bedevere-bot bedevere-bot added the awaiting core review label Apr 12, 2023
@markshannon markshannon changed the title Code cleanup GH-103082: Code cleanup from review. Apr 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 12, 2023
Implement and document PEP 669. #103082
Closed
3 of 4 tasks
@markshannon markshannon added the skip news label Apr 12, 2023
@markshannon
markshannon requested a review from erlend-aasland April 12, 2023 13:07
@markshannon
markshannon marked this pull request as ready for review April 12, 2023 13:07
Fidget-Spinner
Fidget-Spinner reviewed Apr 12, 2023
View reviewed changes
Comment thread Python/instrumentation.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
Follow PEP 7
63f7319
erlend-aasland
erlend-aasland reviewed Apr 13, 2023
View reviewed changes
Comment thread Python/instrumentation.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/instrumentation.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/instrumentation.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Apr 13, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 13, 2023
@JelleZijlstra

JelleZijlstra commented Apr 29, 2023

Copy link
Copy Markdown
Member

I'm not sure why I can't merge this, maybe @Fidget-Spinner has to approve explicitly?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Apr 29, 2023
View reviewed changes
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) April 29, 2023 03:35
Fidget-Spinner
Fidget-Spinner approved these changes Apr 29, 2023
View reviewed changes
@JelleZijlstra JelleZijlstra closed this Apr 29, 2023
auto-merge was automatically disabled April 29, 2023 04:23

Pull request was closed

@JelleZijlstra JelleZijlstra reopened this Apr 29, 2023
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) April 29, 2023 04:24
@JelleZijlstra
JelleZijlstra merged commit 738c226 into python:main Apr 29, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 29, 2023
@markshannon
markshannon deleted the pep-669-review branch September 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@markshannon @JelleZijlstra @erlend-aasland @Fidget-Spinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.