Description

markshannon

opened on Mar 28, 2023

Issue body actions

Now that PEP 669 is accepted, it needs to be implemented and documented.

• Implement the PEP
• Decide on and implement policy for monitors seeing the code in other monitors.
• Document the PEP
• Use "macro" instructions to reduce code duplication in bytecodes.c

Linked PRs

• GH-103082: Implementation of PEP 669: Low Impact Monitoring for CPython #103083
• GH-103082: Code cleanup from review. #103474
• GH-103082: Turn on branch events for FOR_ITER instructions. #103507
• gh-103082: Fix shifted field initialization in instrumentation.c #103561
• GH-103082: Filter LINE events in VM, to simplify tool implementation. #104387
• GH-103082: Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS #107069
• [3.12] GH-103082: Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS (#107069) #107075
• GH-103082: Document PEP-669: Low Impact Monitoring for CPython #107772
• gh-103082: use IS_VALID_OPCODE instead of _PyOpcode_OpName to check if an opcode is defined #107882
• gh-103082: remove assumption that INSTRUMENTED_LINE is the last instrumented opcode #107978
• [3.12] GH-103082: Document PEP-669: Low Impact Monitoring for CPython (GH-107772) #108909
• [3.12] GH-103082: Clean up the sys.monitoring docs #111048

Activity

1. markshannon

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on Mar 28, 2023
2. markshannon commented on Mar 31, 2023

   

   markshannon

   on Mar 31, 2023

   MemberAuthor

   More actions

   Also needs to be added to the "What's new" and the PEP needs to be marked as accepted/final.
3. AlexWaygood

   added

   3.12only security fixesonly security fixes

   on Mar 31, 2023
4. markshannon

   changed the title [-]Implement PEP 669.[/-] [+]Implement and document PEP 669.[/+] on Apr 5, 2023
5. markshannon commented on Apr 5, 2023

   

   markshannon

   on Apr 5, 2023

   MemberAuthor

   More actions

   Specific things to document (that aren't clear from the PEP) (from comments by @gvanrossum):

   event_set is a "set" constructed by OR-ing various events together (a common C idiom of course but not apparent until you see their integer values).

   From GVR: "The naming of the CALL and RETURN/RAISE events is a bit confusing -- we have CALL (universal), C_RETURN/PY_RETURN (per language), but then C_RAISE and RAISE -- why isn't the latter PY_RAISE, just for consistency?"

   There are good reasons for this design, so they should be documented.

   Reacted by Guido van Rossum
6. markshannon

   added 2 commits that reference this issue on Apr 12, 2023

   GH-103082: Implementation of PEP 669: Low Impact Monitoring for CPyth…

   411b169

   GH-103082: Turn on branch events for FOR_ITER instructions. (#103507)

   70e0a28
7. carljm

   added a commit that references this issue on Apr 13, 2023

   Merge branch 'main' into superopt

   9384106
8. aisk

   added a commit that references this issue on Apr 18, 2023

   pythonGH-103082: Implementation of PEP 669: Low Impact Monitoring for…

   989fa92
9. pablogsal commented on Apr 18, 2023

   

   pablogsal

   on Apr 18, 2023

   Member

   More actions

   Seems that this PR (#103083) has broken the tracerefs buildbot:

   https://buildbot.python.org/all/#/builders/484/builds/3091
10. pablogsal commented on Apr 18, 2023

    

    pablogsal

    on Apr 18, 2023

    Member

    More actions

    See also #103083 (comment)
11. markshannon

    added a commit that references this issue on Apr 21, 2023

    gh-103082: Fix shifted field initialization in `instrumentation.c` (G…

    a4967d9
12. JelleZijlstra

    added a commit that references this issue on Apr 29, 2023

    GH-103082: Code cleanup in instrumentation code (#103474)

    738c226
13. markshannon

    added a commit that references this issue on May 12, 2023

    GH-103082: Filter LINE events in VM, to simplify tool implementation. (…

    45f5aa8
14. carljm

    added a commit that references this issue on May 12, 2023

    Merge branch 'main' into supermon

    8efd7c6
15. 13 remaining items
16. iritkatriel

    added 4 commits that reference this issue on Aug 15, 2023

    pythongh-103082: remove assumption that INSTRUMENTED_LINE is the last…

    f04ce13

    gh-103082: remove assumption that INSTRUMENTED_LINE is the last instr…

    971a4c2

    pythongh-103082: remove assumption that INSTRUMENTED_LINE is the last…

    ec3cb64

    pythongh-103082: remove assumption that INSTRUMENTED_LINE is the last…

    7337a4b
17. markshannon

    added a commit that references this issue on Sep 5, 2023

    GH-103082: Document PEP-669: Low Impact Monitoring for CPython (GH-10…

    8b515f6
18. miss-islington

    added a commit that references this issue on Sep 5, 2023

    pythonGH-103082: Document PEP-669: Low Impact Monitoring for CPython (p…

    75d5382
19. Yhg1s

    added a commit that references this issue on Sep 5, 2023

    [3.12] GH-103082: Document PEP-669: Low Impact Monitoring for CPython (…

    578b3ea
20. AA-Turner commented on Sep 8, 2023

    

    AA-Turner

    on Sep 8, 2023

    Member

    More actions

    Is this issue now complete given #107772?
21. brandtbucher

    added 3 commits that reference this issue on Oct 18, 2023

    GH-103082: Clean up the sys.monitoring docs (GH-110532)

    1991694

    [3.12] pythonGH-103082: Clean up the sys.monitoring docs (pythonGH-11…

    2cc9770

    [3.12] GH-103082: Clean up the sys.monitoring docs (GH-111048)

    d312135
22. iritkatriel

    added

    interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

    on Nov 29, 2023
23. markshannon

    closed this as completedon Jan 5, 2024
24. aisk

    added a commit that references this issue on Feb 11, 2024

    pythonGH-103082: Clean up the sys.monitoring docs (pythonGH-110532)

    9269d3a
25. Glyphack

    added a commit that references this issue on Sep 2, 2024

    pythonGH-103082: Clean up the sys.monitoring docs (pythonGH-110532)

    effa03d

Issue actions