GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-67230: document new csv quoting modes in whatsnew (gh-103491) by smontanaro · Pull Request #103491 · python/cpython Conversation
|
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
This interface is horrible. I see a change was rewuested by @merwok but can't see what it is. So... I have made the requested changes; please review again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for making the requested changes! @merwok: please review the changes made to this pull request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Ah! «requested changes» is a review status (others are «approved» and «commented») |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@smontanaro looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@smontanaro <https://github.com/smontanaro> looks good! I tried to do
this myself last night, but I was at my kid's soccer practice and
discovered that the official iPhone GitHub app does not have all the
functionality of the web GUI. 😢
Funny thing. I discovered the same thing about the Android app.
… Message ID: ***@***.***>
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@smontanaro were you responsible for the csv.QUOTE_NULL? You're an absolute legend! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Not exactly. Someone else suggested it years ago. I tend to catch most proposed changes to the csv module... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.