GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-67230: document new csv quoting modes in whatsnew (gh-103491) by smontanaro · Pull Request #103491 · python/cpython

Conversation

@smontanaro

@smontanaro smontanaro commented Apr 12, 2023 •
edited by merwok
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add blurb about recent change to csv.

  • Issue: csv writer needs more quoting rules #67230

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@smontanaro
Update 3.12.rst
115ad5e
Add blurb about changes to :mod:`csv`.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 12, 2023
@smontanaro smontanaro mentioned this pull request Apr 12, 2023
csv writer needs more quoting rules #67230
Closed
@merwok merwok changed the title Update 3.12.rst bpo-67230: document new csv quoting modes in whatsnew Apr 12, 2023
@merwok merwok changed the title bpo-67230: document new csv quoting modes in whatsnew gh-67230: document new csv quoting modes in whatsnew Apr 12, 2023
merwok
merwok requested changes Apr 12, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Apr 12, 2023
@bedevere-bot

bedevere-bot commented Apr 12, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@merwok
fix references
dcef251
merwok
merwok reviewed Apr 12, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@merwok merwok self-assigned this Apr 12, 2023
@smontanaro
fix wording
c8ab320
@smontanaro

smontanaro commented Apr 13, 2023

Copy link
Copy Markdown
Contributor Author

This interface is horrible. I see a change was rewuested by @merwok but can't see what it is. So...

I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Apr 13, 2023
@bedevere-bot

bedevere-bot commented Apr 13, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@merwok: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot
bedevere-bot requested a review from merwok April 13, 2023 00:41
@merwok

merwok commented Apr 13, 2023

Copy link
Copy Markdown
Member

I see a change was requested by merwok but can't see what it is. So...

Ah! «requested changes» is a review status (others are «approved» and «commented»)
Comments can be standalone or part of a review; I used the latter mode, made a few comments (some being change suggestions) and published my review with the «changes requested» status. Then I applied some of my suggested changes directly. So you saw «changes requested», some hidden comments («resolved» by the application of the suggestion), and one comment about the wording.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@merwok merwok changed the title gh-67230: document new csv quoting modes in whatsnew gh-67230: document new csv quoting modes in whatsnew (gh-103491) Apr 13, 2023
@merwok
merwok merged commit fb38c1b into python:main Apr 13, 2023
@bedevere-bot bedevere-bot removed the awaiting change review label Apr 13, 2023
@samwyse

samwyse commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

@smontanaro looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@smontanaro

smontanaro commented Apr 13, 2023 via email

Copy link
Copy Markdown
Contributor Author
@smontanaro <https://github.com/smontanaro> looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢
Funny thing. I discovered the same thing about the Android app.
…
Message ID: ***@***.***>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@smontanaro @aisk
pythongh-67230: document new csv quoting modes in whatsnew (pythongh-…
6eb7a12
…103491)
@chaeynz

chaeynz commented Oct 6, 2023

Copy link
Copy Markdown

@smontanaro were you responsible for the csv.QUOTE_NULL?

You're an absolute legend!
I am working a project where I need exactly this, thank you so much! :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@smontanaro

smontanaro commented Oct 6, 2023

Copy link
Copy Markdown
Contributor Author

Not exactly. Someone else suggested it years ago. I tend to catch most proposed changes to the csv module...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

KNGSJ

This comment was marked as off-topic.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok Awaiting requested review from merwok
1 more reviewer
@KNGSJ KNGSJ KNGSJ left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@merwok merwok

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@smontanaro @bedevere-bot @merwok @samwyse @chaeynz @KNGSJ
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.