GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103693: Add convenience variable feature to `pdb` by gaogaotiantian · Pull Request #103694 · python/cpython

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented Apr 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add convenience variables to pdb #103693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gaogaotiantian added 2 commits April 22, 2023 14:03
@gaogaotiantian
Add convenience variable feature
7db9d37
@gaogaotiantian
Change _return to _retval
f7a11af
@bedevere-bot bedevere-bot mentioned this pull request Apr 22, 2023
Add convenience variables to pdb #103693
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 22, 2023
blurb-it Bot and others added 2 commits April 22, 2023 21:34
@blurb-it
📜🤖 Added by blurb_it.
a202abf
@gaogaotiantian
Use exception value instead of tuple
1415210 
Make _exception non-persistent
@gaogaotiantian

gaogaotiantian commented May 1, 2023

Copy link
Copy Markdown
Member Author

Hi @iritkatriel , do you think you could give this a review so it can make 3.12?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed May 1, 2023
View reviewed changes
Comment thread Doc/library/pdb.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/pdb.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/pdb.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/pdb.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2023-04-22-21-34-13.gh-issue-103693.SBtuLQ.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented May 1, 2023

Copy link
Copy Markdown
Member

This needs to be mentioned in "what's new in 3.12" as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gaogaotiantian

gaogaotiantian commented May 1, 2023

Copy link
Copy Markdown
Member Author

This needs to be mentioned in "what's new in 3.12" as well.

Should I do this in this PR or it's something that should be taken care of later?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented May 1, 2023

Copy link
Copy Markdown
Member

This needs to be mentioned in "what's new in 3.12" as well.

Should I do this in this PR or it's something that should be taken care of later?

In this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gaogaotiantian and others added 2 commits May 1, 2023 15:31
@gaogaotiantian @iritkatriel
Update Doc/library/pdb.rst
ac23148 
Co-authored-by: Irit Katriel <[email protected]>
@gaogaotiantian
Update docs and whatsnew
150250b
@gaogaotiantian

gaogaotiantian commented May 1, 2023

Copy link
Copy Markdown
Member Author

I added the whatsnew entry but not sure if that's good. There's no new function added so I did not link anything.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed May 1, 2023
View reviewed changes
Comment thread Doc/library/pdb.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented May 1, 2023

Copy link
Copy Markdown
Member

I added the whatsnew entry but not sure if that's good. There's no new function added so I did not link anything.

@CAM-Gerlach any advice or shall we leave it as is?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed May 1, 2023
View reviewed changes
Comment thread Lib/pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gaogaotiantian @iritkatriel
Update Doc/library/pdb.rst
f626d36 
Co-authored-by: Irit Katriel <[email protected]>
iritkatriel
iritkatriel approved these changes May 3, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 3, 2023
@iritkatriel
iritkatriel merged commit 0fc58c6 into python:main May 3, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 3, 2023
@erlend-aasland erlend-aasland mentioned this pull request May 3, 2023
gh-104146: Remove unused 'second_pass_replacements' from clinic.py #104147
Merged
@gaogaotiantian
gaogaotiantian deleted the pdb-convenience-variable branch May 4, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gaogaotiantian @iritkatriel @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.